-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removal cancel #9259
Fix removal cancel #9259
Conversation
Signed-off-by: Igor Kozhukhov <[email protected]>
ec03607
to
c39d901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we've observed this at least once as well in the CI.
Test: /usr/share/zfs/zfs-tests/tests/functional/removal/removal_cancel (run as root) [00:17] [FAIL]
16:56:10.78 NOTE: begin default_setup_noexit
16:56:10.95 SUCCESS: zpool create -f testpool loop0
16:56:10.97 SUCCESS: zfs create testpool/testfs
16:56:11.04 SUCCESS: zfs set mountpoint=/mnt/testdir testpool/testfs
16:56:11.04 SUCCESS: default_setup_noexit loop0
16:56:11.05 SUCCESS: mkfile -n 1g //mnt/testdir/00
16:56:18.82 SUCCESS: randwritecomp //mnt/testdir/00 12500
16:56:19.19 SUCCESS: zpool add -f testpool loop2
16:56:26.84 SUCCESS: zpool remove testpool loop0
16:56:27.84 SUCCESS: sleep 1
16:56:27.85 SUCCESS: set_tunable32 zfs_removal_suspend_progress 1
16:56:27.85 pool: testpool
16:56:27.85 state: ONLINE
16:56:27.85 scan: none requested
16:56:27.85 remove: Removal of vdev 0 copied 801M in 0h0m, completed on Thu Aug 22 16:56:27 2019
16:56:27.85 54.3K memory used for removed device mappings
16:56:27.85 config:
16:56:27.85
16:56:27.85 NAME STATE READ WRITE CKSUM
16:56:27.85 testpool ONLINE 0 0 0
16:56:27.85 loop2 ONLINE 0 0 0
16:56:27.85
16:56:27.85 errors: No known data errors
16:56:27.86 SUCCESS: zpool status testpool
16:56:27.86 cannot cancel removal: operation is not in progress
16:56:27.86 ERROR: zpool remove -s testpool exited 1
Codecov Report
@@ Coverage Diff @@
## master #9259 +/- ##
==========================================
- Coverage 79.18% 78.97% -0.22%
==========================================
Files 400 400
Lines 122035 122034 -1
==========================================
- Hits 96634 96376 -258
- Misses 25401 25658 +257
Continue to review full report at Codecov.
|
Create a larger file to extend the time required to perform the removal. Occasional failures were observed due to the removal completing before the cancel could be requested. Reviewed-by: George Melikov <[email protected]> Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Igor Kozhukhov <[email protected]> Closes openzfs#9259
Create a larger file to extend the time required to perform the removal. Occasional failures were observed due to the removal completing before the cancel could be requested. Reviewed-by: George Melikov <[email protected]> Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Igor Kozhukhov <[email protected]> Closes openzfs#9259
Create a larger file to extend the time required to perform the removal. Occasional failures were observed due to the removal completing before the cancel could be requested. Reviewed-by: George Melikov <[email protected]> Reviewed-by: John Kennedy <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Igor Kozhukhov <[email protected]> Closes #9259
test failed due to fast operations on DilOS
original fail:
after update - increase test data - this test PASS on DilOS
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.