Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in tests/ #9250

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix typos in tests/ #9250

merged 1 commit into from
Sep 3, 2019

Conversation

Gelma
Copy link
Contributor

@Gelma Gelma commented Aug 29, 2019

No description provided.

tests/zfs-tests/include/libtest.shlib Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost
Copy link

ghost commented Aug 29, 2019

Please squash the commits and remember to sign-off in the commit message.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 29, 2019
@Gelma
Copy link
Contributor Author

Gelma commented Aug 29, 2019

Please squash the commits and remember to sign-off in the commit message.

Ok, I try to squash in this PR and see what happen,

@Gelma
Copy link
Contributor Author

Gelma commented Aug 29, 2019

Ok, squashed and seems correct (comparing before and after).
Please have a look

@ghost
Copy link

ghost commented Aug 29, 2019

Ok, squashed and seems correct (comparing before and after).
Please have a look

Looks good, thanks.

Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my two comments, this looks good to go. Thanks!

tests/zfs-tests/include/libtest.shlib Outdated Show resolved Hide resolved
Thanks a lot for patch review to @freqlabs

Signed-off-by: Andrea Gelmini <[email protected]>
@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #9250 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9250      +/-   ##
==========================================
- Coverage   79.27%   79.14%   -0.13%     
==========================================
  Files         400      400              
  Lines      122034   122012      -22     
==========================================
- Hits        96741    96570     -171     
- Misses      25293    25442     +149
Flag Coverage Δ
#kernel 79.71% <ø> (-0.07%) ⬇️
#user 66.85% <ø> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c953960...ea34384. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 3, 2019
@behlendorf behlendorf merged commit c6e457d into openzfs:master Sep 3, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Andrea Gelmini <[email protected]>
Closes openzfs#9250
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Andrea Gelmini <[email protected]>
Closes openzfs#9250
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Andrea Gelmini <[email protected]>
Closes #9250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants