Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in tests/ #9242

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix typos in tests/ #9242

merged 1 commit into from
Sep 3, 2019

Conversation

Gelma
Copy link
Contributor

@Gelma Gelma commented Aug 29, 2019

No description provided.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 29, 2019
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though I submitted a couple optional comments.

Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in other comments.

Thanks a lot for patch review to
@freqlabs and @rlaager

Signed-off-by: Andrea Gelmini <[email protected]>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #9242 into master will decrease coverage by 1.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9242      +/-   ##
==========================================
- Coverage   79.31%   77.49%   -1.83%     
==========================================
  Files         400      389      -11     
  Lines      122034   121539     -495     
==========================================
- Hits        96792    94185    -2607     
- Misses      25242    27354    +2112
Flag Coverage Δ
#kernel 76.99% <ø> (-2.83%) ⬇️
#user 66.14% <ø> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c953960...4b7fa54. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 3, 2019
@behlendorf behlendorf merged commit ade306a into openzfs:master Sep 3, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Andrea Gelmini <[email protected]>
Closes openzfs#9242
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Andrea Gelmini <[email protected]>
Closes openzfs#9242
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Andrea Gelmini <[email protected]>
Closes #9242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants