Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix channel programs on s390x #9080

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Fix channel programs on s390x #9080

merged 1 commit into from
Jul 29, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #8992

Description

When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long. They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

How Has This Been Tested?

Locally tested by @ColinIanKing by running the ZTS tests on a s390x system.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 25, 2019
@behlendorf behlendorf requested a review from don-brady July 25, 2019 21:41
@behlendorf behlendorf mentioned this pull request Jul 25, 2019
Closed
@behlendorf
Fix channel programs on s390x
7837305 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#8992
@behlendorf behlendorf requested a review from tonyhutter July 26, 2019 18:36
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 29, 2019
@behlendorf behlendorf merged commit adf495e into openzfs:master Jul 29, 2019
allanjude pushed a commit to allanjude/zfs that referenced this pull request Aug 12, 2019
@behlendorf @allanjude
Fix channel programs on s390x
26a60c9 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
e06f190 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
e929bf5 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
76bf266 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
a7d2e48 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
598cb46 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
f76b29e 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
1bd292c 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@behlendorf @tonyhutter
Fix channel programs on s390x
8c00159 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #8992
Closes #9080
allanjude pushed a commit to allanjude/zfs that referenced this pull request Oct 13, 2019
@behlendorf @allanjude
Fix channel programs on s390x
3c5ce28 
When adapting the original sources for s390x the JMP_BUF_CNT was
mistakenly halved due to an incorrect assumption of the size of
a unsigned long.  They are 8 bytes for the s390x architecture.
Increase JMP_BUF_CNT accordingly.

Authored-by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reported-by: Colin Ian King <canonical.com>
Tested-by: Colin Ian King <canonical.com>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8992
Closes openzfs#9080
@behlendorf behlendorf deleted the fix-s390x branch April 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@don-brady don-brady Awaiting requested review from don-brady

@tonyhutter tonyhutter Awaiting requested review from tonyhutter

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf