Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #8934 Large kmem_alloc #9011

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Fixes: #8934 Large kmem_alloc #9011

merged 1 commit into from
Jul 10, 2019

Conversation

nmattis
Copy link
Contributor

@nmattis nmattis commented Jul 10, 2019

Motivation and Context

Fixes #8934

Description

A large allocation over the spl_kmem_alloc_warn value was being performed by the vdev_indirect_births_open function. Switched to vmem_alloc interface as specified for large allocations. Changed the subsequent frees to match.

How Has This Been Tested?

Built local in Ubuntu 19.04 to replicate the environment described in the issue, tried to reproduce the issue with the changes applied and could not. Ran the test suite against the changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@nmattis
Fixes: openzfs#8934 Large kmem_alloc
197ac61 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
tcaputi
tcaputi approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@tcaputi tcaputi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 10, 2019 •
edited
Loading

Codecov Report

Merging #9011 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9011      +/-   ##
==========================================
- Coverage   78.58%   78.42%   -0.17%     
==========================================
  Files         401      401              
  Lines      120146   120146              
==========================================
- Hits        94419    94226     -193     
- Misses      25727    25920     +193
Flag Coverage Δ
#kernel 79.38% <100%> (-0.07%) ⬇️
#user 66.07% <75%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fad92...197ac61. Read the comment docs.

behlendorf
behlendorf approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jul 10, 2019
@behlendorf behlendorf merged commit d230a65 into openzfs:master Jul 10, 2019
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
@nmattis
Fixes: openzfs#8934 Large kmem_alloc
22a0b64 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
Closes openzfs#9011
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
@nmattis
Fixes: openzfs#8934 Large kmem_alloc
0d12719 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
Closes openzfs#9011
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@nmattis @tonyhutter
Fixes: openzfs#8934 Large kmem_alloc
4b2d3b3 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
Closes openzfs#9011
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@nmattis @tonyhutter
Fixes: openzfs#8934 Large kmem_alloc
10dc94e 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
Closes openzfs#9011
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@nmattis @tonyhutter
Fixes: openzfs#8934 Large kmem_alloc
3cf883f 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
Closes openzfs#9011
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@nmattis @tonyhutter
Fixes: openzfs#8934 Large kmem_alloc
3da423f 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
Closes openzfs#9011
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@nmattis @tonyhutter
Fixes: openzfs#8934 Large kmem_alloc
9349981 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes openzfs#8934
Closes openzfs#9011
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@nmattis @tonyhutter
Fixes: #8934 Large kmem_alloc
cf966cb 
Large allocation over the spl_kmem_alloc_warn value was being performed.
Switched to vmem_alloc interface as specified for large allocations.
Changed the subsequent frees to match.

Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: nmattis <[email protected]>
Closes #8934
Closes #9011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcaputi tcaputi tcaputi approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Large kmem_alloc(76800, 0x0)
3 participants
@nmattis @behlendorf @tcaputi