Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better user experience for errata 4 #8504

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

tcaputi
Copy link
Contributor

@tcaputi tcaputi commented Mar 14, 2019

This patch attempts to address some user concerns that have arisen
since errata 4 was introduced.

  • The errata warning has been made less scary for users without
    any encrypted datasets.

  • The errata warning now clears itself without a pool reimport if
    the bookmark_v2 feature is enabled and no encrypted datasets
    exist.

  • It is no longer possible to create new encrypted datasets without
    enabling the bookmark_v2 feature, thus helping to ensure that the
    errata is resolved.

Signed-off-by: Tom Caputi [email protected]

Motivation and Context

#8503

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tcaputi tcaputi force-pushed the errata4_doc_update branch from 8cbdd0f to 5084edf Compare March 14, 2019 15:54
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #8504 into master will decrease coverage by 0.15%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8504      +/-   ##
==========================================
- Coverage   78.67%   78.51%   -0.16%     
==========================================
  Files         380      380              
  Lines      116230   116238       +8     
==========================================
- Hits        91440    91270     -170     
- Misses      24790    24968     +178
Flag Coverage Δ
#kernel 79.11% <62.5%> (+0.09%) ⬆️
#user 67.01% <33.33%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98310e5...4ee0497. Read the comment docs.

@tcaputi tcaputi force-pushed the errata4_doc_update branch from 5084edf to 3a9bf8d Compare March 14, 2019 17:32
This patch attempts to address some user concerns that have arisen
since errata 4 was introduced.

* The errata warning has been made less scary for users without
  any encrypted datasets.

* The errata warning now clears itself without a pool reimport if
  the bookmark_v2 feature is enabled and no encrypted datasets
  exist.

* It is no longer possible to create new encrypted datasets without
  enabling the bookmark_v2 feature, thus helping to ensure that the
  errata is resolved.

Signed-off-by: Tom Caputi <[email protected]>
@tcaputi tcaputi force-pushed the errata4_doc_update branch from 3a9bf8d to 4ee0497 Compare March 14, 2019 18:06
@behlendorf behlendorf merged commit eaed840 into openzfs:master Mar 14, 2019
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants