Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zfs-zed hard dep from zfs-share init script #8447

Merged
merged 5 commits into from
Feb 28, 2019
Merged

Remove zfs-zed hard dep from zfs-share init script #8447

merged 5 commits into from
Feb 28, 2019

Conversation

beren12
Copy link
Contributor

@beren12 beren12 commented Feb 23, 2019

The zfs-share init script has a requires: dependency on zfs-zed. It doesn't seem to be needed to start, it's already in the "should start/stop" list, and it can break downstream packaging where zed is split from the main package: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915831

the systemd scripts do not have this dependency listed either.

Motivation and Context

Debian splits off zed and the init system has troubles since there's a circ. dep.

Description

How Has This Been Tested?

Tested in debian stretch and works w/o issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #8447 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8447      +/-   ##
==========================================
+ Coverage   78.56%    78.6%   +0.03%     
==========================================
  Files         380      380              
  Lines      116001   116003       +2     
==========================================
+ Hits        91137    91179      +42     
+ Misses      24864    24824      -40
Flag Coverage Δ
#kernel 79.04% <ø> (ø) ⬆️
#user 67.27% <ø> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44a3ec...7fad339. Read the comment docs.

@bunder2015 bunder2015 added the Status: Code Review Needed Ready for review and testing label Feb 23, 2019
Copy link
Contributor

@bunder2015 bunder2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentoo doesn't seem to use these for dependency tracking (we use rc_need), but in theory we shouldn't need zed to share datasets.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 28, 2019
@behlendorf behlendorf merged commit 3a1f2d5 into openzfs:master Feb 28, 2019
@beren12 beren12 deleted the init-fix branch March 3, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants