-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed suggestion to use root dataset as bootfs #8247
Conversation
The dracut howto proposed to boot from the root dataset of a pool. Apart from this giving problems when booting (as the code seems to expect a child dataset and creates an illegal dataset name when using the root dataset) the technical limitations of the root dataset (among others the inability to rename or destroy through the `zfs` command) resulted in the general consensus to only use it as a container for the datasets in the pool - not as a filesystem itself. Removed the idea to boot from the root dataset. Signed-off-by: Gregor Kopka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for this because of bugs like #1548 (although I wish we could close one that instead)
Codecov Report
@@ Coverage Diff @@
## master #8247 +/- ##
==========================================
- Coverage 78.46% 78.35% -0.11%
==========================================
Files 379 379
Lines 114924 114924
==========================================
- Hits 90176 90050 -126
- Misses 24748 24874 +126
Continue to review full report at Codecov.
|
Removing 6 lines from a non-code file results in not building and decreased coverage... I'm confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
The kernel issue is unrelated, the (slightly) decreased coverage is because the testing isn't entirely deterministic. Nothing to see here. |
Motivation and Context
The dracut howto proposed to boot from the root dataset of a pool.
Apart from this giving problems when booting (as the code seems to expect a child dataset and creates an illegal dataset name when using the root dataset) the technical limitations of the root dataset (among others the inability to rename or destroy through the
zfs
subcommand) lead to the general consensus that it's best to only use it as a container for the datasets in the pool - not as a filesystem itself.Description
Removed the idea to boot from the root dataset from the dracut howto.
How Has This Been Tested?
Documentation change.
Types of changes
Checklist:
Signed-off-by
.