Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Update project quota tests #8043

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Resolve project quota failures observed in Fedora Rawhide.

Description

http://build.zfsonlinux.org/builders/Fedora%20Rawhide%20x86_64%20%28TEST%29/builds/1525/steps/shell_9/logs/summary

e2fsprogs v1.44.1, which provides lsattr, added a new attibute for ext3 called "verity". It is reported after the project quota flag as a 'V' character in the lsattr output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use a pattern which will match the expected output in both cases.

How Has This Been Tested?

Manually tested with e2fsprogs v1.44.4-48-g29d78e01 and verified correct behavior. Pending results from CI for testing on a wider range of lsattr versions.

NOTE: The e2fsprogs v1.44.4-1 package from Rawhide contains a bug which results in the V always being able when P is also set. This was resolved in e2fsprogs but the updated version hasn't yet made it to Rawhide.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

e2fsprogs v1.44.1, which provides lsattr, added a new attibute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added the Status: Work in Progress Not yet ready for general review label Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #8043 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8043      +/-   ##
==========================================
- Coverage   78.58%   78.55%   -0.03%     
==========================================
  Files         377      377              
  Lines      114404   114404              
==========================================
- Hits        89900    89869      -31     
- Misses      24504    24535      +31
Flag Coverage Δ
#kernel 78.77% <ø> (-0.04%) ⬇️
#user 67.53% <ø> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f438c5...9d4cc8e. Read the comment docs.

@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Oct 19, 2018
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 22, 2018
@behlendorf behlendorf merged commit 3449243 into openzfs:master Oct 24, 2018
ghfields pushed a commit to ghfields/zfs that referenced this pull request Oct 29, 2018
e2fsprogs v1.44.1, which provides lsattr, added a new attribute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8043
BrainSlayer pushed a commit to BrainSlayer/zfs that referenced this pull request Nov 4, 2018
e2fsprogs v1.44.1, which provides lsattr, added a new attribute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8043
GregorKopka pushed a commit to GregorKopka/zfs that referenced this pull request Jan 7, 2019
e2fsprogs v1.44.1, which provides lsattr, added a new attribute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8043
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Sep 22, 2019
e2fsprogs v1.44.1, which provides lsattr, added a new attribute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8043
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Sep 22, 2019
e2fsprogs v1.44.1, which provides lsattr, added a new attribute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8043
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Sep 22, 2019
e2fsprogs v1.44.1, which provides lsattr, added a new attribute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8043
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Sep 22, 2019
e2fsprogs v1.44.1, which provides lsattr, added a new attribute
for ext3 called "verity".  It is reported after the project quota
flag as a 'V' character in the `lsattr` output.

Update projectid_001_pos.ksh and projecttree_001_pos.ksh to use
a pattern which will match the expected output in both cases.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#8043
@behlendorf behlendorf deleted the projectquota-fix branch April 19, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants