Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenZFS 9688 - aggsum_fini leaks memory #8042

Closed
wants to merge 1 commit into from
Closed

OpenZFS 9688 - aggsum_fini leaks memory #8042

wants to merge 1 commit into from

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

OpenZFS-issue: https://www.illumos.org/issues/9688
OpenZFS-commit: openzfs/openzfs@29bf2d68be

Description

Pulled mainly to keep the code in sync. The memory leaks were already resolved in the initial port, and Linux's slab cache behaves differently so arc_state_fini() reordering is only cosmetic.

How Has This Been Tested?

Locally built, pending CI results.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@pcd1193182 @behlendorf
OpenZFS 9688 - aggsum_fini leaks memory
9833fdc 
Porting Notes:
- Most of these fixes were applied in the original 37fb3e4
  commit when this change was ported for Linux.

Authored by: Paul Dagnelie <[email protected]>
Reviewed by: Serapheim Dimitropoulos <[email protected]>
Reviewed by: Matt Ahrens <[email protected]>
Reviewed by: Prashanth Sreenivasa <[email protected]>
Reviewed by: Jorgen Lundman <[email protected]>
Reviewed by: Igor Kozhukhov <[email protected]>
Approved by: Robert Mustacchi <[email protected]>
Ported-by: Brian Behlendorf <[email protected]>

OpenZFS-issue: https://www.illumos.org/issues/9688
OpenZFS-commit: openzfs/openzfs@29bf2d68be
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 18, 2018
gmelikov
gmelikov approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented Oct 19, 2018 •
edited
Loading

Codecov Report

Merging #8042 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8042      +/-   ##
==========================================
- Coverage   78.46%   78.31%   -0.15%     
==========================================
  Files         377      377              
  Lines      114404   114404              
==========================================
- Hits        89768    89599     -169     
- Misses      24636    24805     +169
Flag Coverage Δ
#kernel 78.77% <100%> (+0.04%) ⬆️
#user 66.85% <100%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f438c5...9833fdc. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 19, 2018
ghfields pushed a commit to ghfields/zfs that referenced this pull request Oct 29, 2018
@pcd1193182 @ghfields
OpenZFS 9688 - aggsum_fini leaks memory
6db1f90 
Porting Notes:
- Most of these fixes were applied in the original 37fb3e4
  commit when this change was ported for Linux.

Authored by: Paul Dagnelie <[email protected]>
Reviewed by: Serapheim Dimitropoulos <[email protected]>
Reviewed by: Matt Ahrens <[email protected]>
Reviewed by: Prashanth Sreenivasa <[email protected]>
Reviewed by: Jorgen Lundman <[email protected]>
Reviewed by: Igor Kozhukhov <[email protected]>
Reviewed by: George Melikov <[email protected]>
Approved by: Robert Mustacchi <[email protected]>
Ported-by: Brian Behlendorf <[email protected]>

OpenZFS-issue: https://www.illumos.org/issues/9688
OpenZFS-commit: openzfs/openzfs@29bf2d68be
Closes openzfs#8042
BrainSlayer pushed a commit to BrainSlayer/zfs that referenced this pull request Nov 4, 2018
@pcd1193182 @BrainSlayer
OpenZFS 9688 - aggsum_fini leaks memory
5219078 
Porting Notes:
- Most of these fixes were applied in the original 37fb3e4
  commit when this change was ported for Linux.

Authored by: Paul Dagnelie <[email protected]>
Reviewed by: Serapheim Dimitropoulos <[email protected]>
Reviewed by: Matt Ahrens <[email protected]>
Reviewed by: Prashanth Sreenivasa <[email protected]>
Reviewed by: Jorgen Lundman <[email protected]>
Reviewed by: Igor Kozhukhov <[email protected]>
Reviewed by: George Melikov <[email protected]>
Approved by: Robert Mustacchi <[email protected]>
Ported-by: Brian Behlendorf <[email protected]>

OpenZFS-issue: https://www.illumos.org/issues/9688
OpenZFS-commit: openzfs/openzfs@29bf2d68be
Closes openzfs#8042
GregorKopka pushed a commit to GregorKopka/zfs that referenced this pull request Jan 7, 2019
@pcd1193182
OpenZFS 9688 - aggsum_fini leaks memory
1d31cd0 
Porting Notes:
- Most of these fixes were applied in the original 37fb3e4
  commit when this change was ported for Linux.

Authored by: Paul Dagnelie <[email protected]>
Reviewed by: Serapheim Dimitropoulos <[email protected]>
Reviewed by: Matt Ahrens <[email protected]>
Reviewed by: Prashanth Sreenivasa <[email protected]>
Reviewed by: Jorgen Lundman <[email protected]>
Reviewed by: Igor Kozhukhov <[email protected]>
Reviewed by: George Melikov <[email protected]>
Approved by: Robert Mustacchi <[email protected]>
Ported-by: Brian Behlendorf <[email protected]>

OpenZFS-issue: https://www.illumos.org/issues/9688
OpenZFS-commit: openzfs/openzfs@29bf2d68be
Closes openzfs#8042
@behlendorf behlendorf deleted the openzfs-9688 branch April 19, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @gmelikov @pcd1193182