Disable GCC stack protector when compiling zvol_id #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a kludge for now,... will Valgrind the code and look for the buffer overflows and correct them as soon as time allows. -- Ross Cameron [email protected] 05/06/2012 @ 18h07
and look for the buffer overflows and correct them as soon as time allows. -- Ross Cameron [email protected] 06/06/2012 @ 15h27
| @@ -157,7 +157,7 @@ CCAS = @CCAS@ | |||
| CCASDEPMODE = @CCASDEPMODE@ | |||
| CCASFLAGS = @CCASFLAGS@ | |||
| CCDEPMODE = @CCDEPMODE@ | |||
| CFLAGS = @CFLAGS@ | |||
| CFLAGS = | |||
There was a problem hiding this comment.
zvol_id fails on hardened GCC profiles removing the "@CFLAGS@" variable allows for compiling zvol_id without stack protection.
Code still needs to be cleaned up with Valgrind but I haven't had time to do this yet.
|
I've merged this as a work around although I want to make sure we run down the root cause so this can be reverted. |
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
Sep 26, 2023
) Bumps [sysinfo](https://github.com/GuillaumeGomez/sysinfo) from 0.28.3 to 0.28.4. - [Release notes](https://github.com/GuillaumeGomez/sysinfo/releases) - [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/master/CHANGELOG.md) - [Commits](https://github.com/GuillaumeGomez/sysinfo/commits) --- updated-dependencies: - dependency-name: sysinfo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a kludge for now,... will Valgrind the code and look for the buffer overflows and correct them as soon as time allows.
Tried adding "-fno-stack-protector" to the CFLAGS in Makefile.in first but this caused a compile error, found that just removing the "@CFLAGS@" variable allowed for compilation and functioning of zvol_id.
-- Ross Cameron
[email protected]
06/06/2012 @ 15h27