Cause autogen.sh to fail if autoreconf fails #7683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change simply detects if autoreconf fails, and if so, causes autogen.sh to fail as well.
Motivation and Context
When doing development, it's possible to forget to add Makefiles or other components to the repository, or to forget to create them at all. If this happens, autoreconf can notice the problem and fail. However, we don't detect this failure. As a result, automated builds will often proceed without knowing anything is wrong, producing obscure and confusing failures later in the build process.
How Has This Been Tested?
This patch has been tested by adding a dependency but not creating the relevant Makefile, and verifying that an automated build fails in a more appropriate place. It has also been tested on builds that should succeed, and it does.
Types of changes
Checklist:
Signed-off-by
.