ZTS: zpool_create_002 clean up leftover filedisk #7439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinatale2
suggested changes
Apr 15, 2018
| @@ -50,14 +50,14 @@ function cleanup | |||
| for pool in $TESTPOOL $TESTPOOL1 $TESTPOOL2 $TESTPOOL3 $TESTPOOL4 \ | |||
| $TESTPOOL5 $TESTPOOL6 | |||
| do | |||
| poolexists $pool && destroy_pool $pool | |||
| poolexists $pool && log_must destroy_pool $pool | |||
There was a problem hiding this comment.
You can actually get rid of the poolexists check. destroy_pool already performs the check. You also don’t want to use log_must, if one destroy fails, you’d still want to attempt the other ones.
zpool_create_002_pos did not clean up filedisk files left over from running the test. Signed-off-by: bunder2015 <[email protected]> Issue #7435
|
Thanks for the tips, adjusted and repushed. |
Codecov Report
@@ Coverage Diff @@
## master #7439 +/- ##
==========================================
+ Coverage 76.59% 76.61% +0.02%
==========================================
Files 335 335
Lines 107017 107017
==========================================
+ Hits 81971 81993 +22
+ Misses 25046 25024 -22
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Apr 15, 2018
dinatale2
approved these changes
Apr 15, 2018
gmelikov
approved these changes
Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zpool_create_002_pos did not clean up filedisk files left over from
running the test.
Motivation and Context
Keeping /var/tmp clean.
Issue #7435
How Has This Been Tested?
Local test runner
Types of changes
Checklist:
Signed-off-by.