Fix zed/udev thrashing due to autoexpand=on #7393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flushing the device and invaliding the page cache to ensure a consistent view of the device is only needed when the device was successfully expanded. Unconditionally performing these operations is safe but it has the side effect of triggering another udev change event which will be handled by the ZED. Signed-off-by: Brian Behlendorf <[email protected]> Issue openzfs#7366
tonyhutter
approved these changes
Apr 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #7393 +/- ##
==========================================
- Coverage 76.39% 76.2% -0.19%
==========================================
Files 329 329
Lines 104248 104249 +1
==========================================
- Hits 79638 79442 -196
- Misses 24610 24807 +197
Continue to review full report at Codecov.
|
gmelikov
approved these changes
Apr 6, 2018
|
Closing. Sounds like this doesn't resolve the issue. We'll need to open a new PR which open the device |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flushing the device and invaliding the page cache to ensure a consistent view of the device is only needed when the device was successfully expanded. Unconditionally performing these operations is safe but it has the side effect of triggering another udev change event which will be handled by the ZED.
Motivation and Context
Issue #7366
How Has This Been Tested?
Buildbot.
Types of changes
Checklist:
Signed-off-by.