Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora 28: Fix misc bounds check compiler warnings #7368

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Fedora 28: Fix misc bounds check compiler warnings #7368

merged 1 commit into from
Apr 4, 2018

Conversation

tonyhutter
Copy link
Contributor

@tonyhutter tonyhutter commented Mar 30, 2018 •
edited
Loading

Description

Fix a bunch of (mostly) sprintf/snprintf truncation compiler warnings that show up on Fedora 28 (GCC 8.0.1).

Motivation and Context

Closes: #7361

How Has This Been Tested?

Ran make on Fedora 28 VM.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@tonyhutter tonyhutter added Type: Building Indicates an issue related to building binaries Status: Work in Progress Not yet ready for general review labels Mar 30, 2018
@codecov
Copy link

codecov bot commented Mar 30, 2018 •
edited
Loading

Codecov Report

Merging #7368 into master will increase coverage by 0.14%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7368      +/-   ##
==========================================
+ Coverage   76.38%   76.52%   +0.14%     
==========================================
  Files         329      329              
  Lines      104214   104214              
==========================================
+ Hits        79606    79753     +147     
+ Misses      24608    24461     -147
Flag Coverage Δ
#kernel 76.19% <ø> (-0.24%) ⬇️
#user 65.93% <68.18%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10adee2...ac4a024. Read the comment docs.

behlendorf
behlendorf requested changes Mar 30, 2018
View reviewed changes
module/zfs/dsl_scan.c Outdated
dsl_scan_phys_t *scnp = &scn->scn_phys;

#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you need to extend this around the dprintf().

@tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
ac4a024 
Fix a bunch of (mostly) sprintf/snprintf truncation compiler
warnings that show up on Fedora 28 (GCC 8.0.1).

Signed-off-by: Tony Hutter <[email protected]>
Closes: openzfs#7361
@tonyhutter tonyhutter removed the Status: Work in Progress Not yet ready for general review label Apr 4, 2018
@tonyhutter tonyhutter changed the title WIP: Fedora 28: Fix misc bounds check compiler warnings Fedora 28: Fix misc bounds check compiler warnings Apr 4, 2018
@behlendorf behlendorf merged commit 21a4f5c into openzfs:master Apr 4, 2018
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Apr 16, 2018
@tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
5201cc3 
Fix a bunch of (mostly) sprintf/snprintf truncation compiler
warnings that show up on Fedora 28 (GCC 8.0.1).

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tony Hutter <[email protected]>
Closes openzfs#7361
Closes openzfs#7368
tonyhutter added a commit to tonyhutter/zfs that referenced this pull request May 4, 2018
@tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
5a3cd57 
Fix a bunch of (mostly) sprintf/snprintf truncation compiler
warnings that show up on Fedora 28 (GCC 8.0.1).

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tony Hutter <[email protected]>
Closes openzfs#7361
Closes openzfs#7368
tonyhutter added a commit that referenced this pull request May 10, 2018
@tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
f5ecab3 
Fix a bunch of (mostly) sprintf/snprintf truncation compiler
warnings that show up on Fedora 28 (GCC 8.0.1).

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tony Hutter <[email protected]>
Closes #7361
Closes #7368
@dioni21 dioni21 mentioned this pull request Aug 25, 2018
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request Aug 26, 2018
@dioni21 @behlendorf
Fedora 28: Fix misc bounds check compiler warnings
5d6ad24 
Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Issue #7368 
Closes #7826 
Closes #7830
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 28, 2018
@dioni21 @tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
191edfd 
Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Issue openzfs#7368 
Closes openzfs#7826 
Closes openzfs#7830
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 30, 2018
@dioni21 @tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
82c96da 
Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Issue openzfs#7368
Closes openzfs#7826
Closes openzfs#7830
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 5, 2018
@dioni21 @tonyhutter
Fedora 28: Fix misc bounds check compiler warnings
3ea1f7f 
Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Issue openzfs#7368
Closes openzfs#7826
Closes openzfs#7830
@dioni21 dioni21 mentioned this pull request Oct 14, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fedora 28: misc bounds check compiler warnings
2 participants
@tonyhutter @behlendorf