OpenZFS 8898 - creating fs with checksum=skein on the boot pools fails

[behlendorf]

Description

# zfs create -o checksum=skein rpool/test
internal error: Result too large
Abort (core dumped)

Not a big deal per se, but should be handled correctly.

Motivation and Context

OpenZFS-issue: https://www.illumos.org/issues/8898
OpenZFS-commit: openzfs/openzfs@9fa2266d9a

How Has This Been Tested?

Merged to OpenZFS, locally builds, pending buildbot results.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commit messages are properly formatted and contain Signed-off-by.
• Change has been approved by a ZFS on Linux member.

[bunder2015]

Sorry to bump, but I thought these were supposed to work in boot configurations, except that grub doesn't understand them? (ie: they should work on efi setups?)

[behlendorf]

It's possible they may, but currently the utilities prevent you from setting these compression types on a bootfs.

https://github.com/zfsonlinux/zfs/blob/master/module/zfs/zfs_ioctl.c#L3937..L3947

[bunder2015]

But skein is a checksum algo, line 4025 shows no restrictions

[behlendorf]

Sorry, I highlighted the wrong block. It should be this check. Both skein and edonr have ZCHECKSUM_FLAG_SALTED set.

[codecov]

Codecov Report

Merging #7031 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #7031      +/-   ##
==========================================
+ Coverage   75.32%   75.37%   +0.04%     
==========================================
  Files         296      296              
  Lines       95520    95522       +2     
==========================================
+ Hits        71954    71997      +43     
+ Misses      23566    23525      -41

Flag	Coverage Δ
#kernel	74.48% <ø> (-0.13%)	⬇️
#user	67.71% <0%> (+0.22%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed9035...6c7d14f. Read the comment docs.