Add missing zfs-import.target to list of systemd services

[Lalufu]

0.7.4 added the zfs-import.target to systemd. This target was missing in the spec file, leading to unwanted unit ordering.

Description

Add missing zfs-import.target to systemd_svcs list.

Motivation and Context

Without this change zfs-import.target is installed but not activated, leading to incorrect unit ordering on startup, and missing mounted file systems.

#6953

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commit messages are properly formatted and contain Signed-off-by.
• Change has been approved by a ZFS on Linux member.

[codecov]

Codecov Report

Merging #6955 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6955      +/-   ##
==========================================
- Coverage   75.43%   75.22%   -0.22%     
==========================================
  Files         296      296              
  Lines       95453    95453              
==========================================
- Hits        72007    71800     -207     
- Misses      23446    23653     +207

Flag	Coverage Δ
#kernel	74.51% <ø> (+0.07%)	⬆️
#user	67.51% <ø> (-0.38%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9b156...168439d. Read the comment docs.

[behlendorf]

@aerusso I wanted to give you a heads up on this issue for the Debian packaging. You'll want to make sure to enable the new systemd zfs-import.target in your 0.7.4 packages. See #6953 for full details.

[Lalufu]

Can we maybe spin a 0.7.4-2 RPM for this? It is just a spec file change.On Dec 14, 2017 19:16, Brian Behlendorf <[email protected]> wrote:@aerusso I wanted to give you a heads up on this issue for the Debian packaging. You'll want to make sure to enable the new systemd zfs-import.target in your 0.7.4 packages. See #6953 for full details. —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

[tonyhutter]

@Lalufu we're going to spin a 0.7.5 release to get the fix out there (along with a handful of some other patches). I'd expect it sometime early next week. Thanks again for reporting the bug and providing a fix!

[aerusso]

@behlendorf It turns out that deb-systemd-helper automatically enables installed systemd units. I incorrectly assumed this was somehow "normal" behavior for systemd units, and that's how it slipped by my testing (i.e., "worked for me"). Sorry.

80b4852, which added zfs-import.target to etc/systemd/system/50-zfs.preset.in did not get included on the stable branch. That particular line might be a good candidate to be cherry-picked into stable. I've also opened #6964, but I think that should be low-priority.

[behlendorf]

@aerusso yes, good point. We do need that preset and will pull it in to 0.7.5. We'll also take a look at #6964.

[behlendorf]

An 0.7.4-2 package has been added to the Fedora and EPEL repositories which enables the zfs-import-target on install. It includes this fix as well as the one line addition to the etc/systemd/system/50-zfs.preset.in. In addition, the relevant wiki has been updated with a recommendation to reset the default presets after upgrading to 0.7.4 .