Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable QAT support in zfs-dkms RPM #6932

Closed
wants to merge 2 commits into from
Closed

Enable QAT support in zfs-dkms RPM #6932

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5997eb5
Enable QAT support in zfs-dkms RPM
daweiq Dec 7, 2017
c85abb0
Enable QAT support in zfs-dkms RPM
daweiq Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/dkms.mkconf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ PRE_BUILD="configure
--with-spl-obj=\${dkms_tree}/spl/\${PACKAGE_VERSION}/\${kernelver}/\${arch}
--with-spl-timeout=300
--with-qat=\${ICP_ROOT}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daweiq is the QAT driver packaged using dkms? If so it would make sense to first check for an installed dkms version and if detected provide that to --with-qat and --with-qat-obj. Then additionally provide a way with an environment variable (or two) to specify a location. Please do this in a way such that -with-qat isn't passed unconditionally to configure when it's not available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@behlendorf QAT driver only provides source code tar ball now. So, we cannot detect the QAT driver source code unless user specific it. After passing this environment variable to configure, the source file check inside configure file will validate the path and decide whether to include QAT or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, then please just update the PR so the --with-qat is only provided to configure when ICP_ROOT is defined. You can use a modified versions of how --enable-debug is provided and check if the environment variable has a non-zero length.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, patch updated.

\$(
[[ -n \${ICP_ROOT} ]] && \\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since ICP_ROOT may not be defined it should be quoted to avoid an error.

{
echo --with-qat=\${ICP_ROOT}
}
)
\$(
[[ -r \${PACKAGE_CONFIG} ]] \\
&& source \${PACKAGE_CONFIG} \\
Expand Down