Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic dependencies in zfs-test package #6868

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

behlendorf
Copy link
Contributor

Description

All of the ZTS test scripts specify /bin/ksh as the interpreter.
Unfortunately, as of Fedora 27 only /usr/bin/ksh is provided by
the package manager. Rather than change all the scripts to
accommodate the latest Fedora disable automatic dependencies
for the zfs-test package. Functionally this will not cause
any problems since /bin is a symlink to /usr/bin.

Motivation and Context

Fix Fedora 27 automated testing.

How Has This Been Tested?

Locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

All of the ZTS test scripts specify /bin/ksh as the interpreter.
Unfortunately, as of Fedora 27 only /usr/bin/ksh is provided by
the package manager.  Rather than change all the scripts to
accommodate the latest Fedora disable automatic dependencies
for the zfs-test package.  Functionally this will not cause
any problems since /bin is a symlink to /usr/bin.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf requested a review from loli10K November 15, 2017 00:04
@behlendorf behlendorf merged commit 13589da into openzfs:master Nov 15, 2017
@codecov
Copy link

codecov bot commented Nov 15, 2017

Codecov Report

Merging #6868 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6868      +/-   ##
==========================================
+ Coverage   75.23%   75.35%   +0.11%     
==========================================
  Files         298      298              
  Lines       94503    94503              
==========================================
+ Hits        71100    71210     +110     
+ Misses      23403    23293     -110
Flag Coverage Δ
#kernel 74.61% <ø> (-0.16%) ⬇️
#user 67.65% <ø> (+0.2%) ⬆️
Impacted Files Coverage Δ
module/icp/algs/skein/skein_port.h 0% <0%> (-100%) ⬇️
module/zfs/arc.c 87.75% <0%> (-1.35%) ⬇️
module/zfs/zap_micro.c 85.23% <0%> (-0.58%) ⬇️
module/icp/api/kcf_mac.c 36.57% <0%> (-0.58%) ⬇️
module/zfs/dnode_sync.c 92.62% <0%> (-0.55%) ⬇️
module/zfs/dsl_deadlist.c 92.43% <0%> (-0.4%) ⬇️
module/icp/algs/modes/ccm.c 83.97% <0%> (-0.33%) ⬇️
module/zfs/dbuf.c 94.67% <0%> (-0.18%) ⬇️
module/zfs/sa.c 84.41% <0%> (-0.13%) ⬇️
module/zfs/zfs_ioctl.c 82.96% <0%> (+0.04%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71788d9...e23ed06. Read the comment docs.

tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 21, 2017
All of the ZTS test scripts specify /bin/ksh as the interpreter.
Unfortunately, as of Fedora 27 only /usr/bin/ksh is provided by
the package manager.  Rather than change all the scripts to
accommodate the latest Fedora disable automatic dependencies
for the zfs-test package.  Functionally this will not cause
any problems since /bin is a symlink to /usr/bin.

Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#6868
@Conan-Kudo
Copy link
Contributor

@behlendorf This is technically a bug for Fedora ksh package. Did anyone ask the ksh maintainer to restore the /bin/ksh Provides?

@Conan-Kudo
Copy link
Contributor

Actually, it looks like this has been fixed: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2094282f35

@behlendorf
Copy link
Contributor Author

@Conan-Kudo yes, this was discussed with the maintainer and addressed as you mentioned above. We may want to back this change out after the dust settles a little bit.

Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Jan 29, 2018
All of the ZTS test scripts specify /bin/ksh as the interpreter.
Unfortunately, as of Fedora 27 only /usr/bin/ksh is provided by
the package manager.  Rather than change all the scripts to
accommodate the latest Fedora disable automatic dependencies
for the zfs-test package.  Functionally this will not cause
any problems since /bin is a symlink to /usr/bin.

Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#6868
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Feb 13, 2018
All of the ZTS test scripts specify /bin/ksh as the interpreter.
Unfortunately, as of Fedora 27 only /usr/bin/ksh is provided by
the package manager.  Rather than change all the scripts to
accommodate the latest Fedora disable automatic dependencies
for the zfs-test package.  Functionally this will not cause
any problems since /bin is a symlink to /usr/bin.

Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#6868
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Apr 28, 2019
All of the ZTS test scripts specify /bin/ksh as the interpreter.
Unfortunately, as of Fedora 27 only /usr/bin/ksh is provided by
the package manager.  Rather than change all the scripts to
accommodate the latest Fedora disable automatic dependencies
for the zfs-test package.  Functionally this will not cause
any problems since /bin is a symlink to /usr/bin.

Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#6868
@behlendorf behlendorf deleted the fedora-test-deps branch April 19, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants