Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined %{systemd_svcs} in RPM scriptlets #6841

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

loli10K
Copy link
Contributor

@loli10K loli10K commented Nov 7, 2017

Description

This allows RPM-based systems to properly control package installation and removal when using systemd. Without this change pre/post-install scripts will not work properly because the custom %{systemd_svcs} macro is not defined:

[root@centos zfs]# rpm -qp --scripts ./zfs-0.7.0-163_gdf1f129.el7.centos.x86_64.rpm 
postinstall scriptlet (using /bin/sh):

if [ $1 -eq 1 ] ; then 
        # Initial installation 
        systemctl preset %{systemd_svcs} >/dev/null 2>&1 || : 
fi 

exit 0
preuninstall scriptlet (using /bin/sh):

if [ $1 -eq 0 ] ; then 
        # Package removal, not upgrade 
        systemctl --no-reload disable %{systemd_svcs} > /dev/null 2>&1 || : 
        systemctl stop %{systemd_svcs} > /dev/null 2>&1 || : 
fi 

exit 0
postuninstall scriptlet (using /bin/sh):

systemctl daemon-reload >/dev/null 2>&1 || :
[root@centos zfs]# 

With patch applied:

[root@centos zfs]# rpm -qp --scripts ./zfs-0.7.0-163_gdf1f129.el7.centos.x86_64.rpm 
postinstall scriptlet (using /bin/sh):

if [ $1 -eq 1 ] ; then 
        # Initial installation 
        systemctl preset zfs-import-cache.service zfs-import-scan.service zfs-mount.service zfs-share.service zfs-zed.service zfs.target >/dev/null 2>&1 || : 
fi 

exit 0
preuninstall scriptlet (using /bin/sh):

if [ $1 -eq 0 ] ; then 
        # Package removal, not upgrade 
        systemctl --no-reload disable zfs-import-cache.service zfs-import-scan.service zfs-mount.service zfs-share.service zfs-zed.service zfs.target > /dev/null 2>&1 || : 
        systemctl stop zfs-import-cache.service zfs-import-scan.service zfs-mount.service zfs-share.service zfs-zed.service zfs.target > /dev/null 2>&1 || : 
fi 

exit 0
postuninstall scriptlet (using /bin/sh):

systemctl daemon-reload >/dev/null 2>&1 || :
[root@centos zfs]# 

Motivation and Context

Fix #6838

How Has This Been Tested?

Local build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

This allows RPM-based systems to properly control package installation
and removal when using systemd.

Signed-off-by: loli10K <[email protected]>
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

@behlendorf behlendorf merged commit 011ef12 into openzfs:master Nov 8, 2017
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 21, 2017
This allows RPM-based systems to properly control package installation
and removal when using systemd.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes openzfs#6838 
Closes openzfs#6841
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Jan 29, 2018
This allows RPM-based systems to properly control package installation
and removal when using systemd.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes openzfs#6838
Closes openzfs#6841
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Feb 13, 2018
This allows RPM-based systems to properly control package installation
and removal when using systemd.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes openzfs#6838
Closes openzfs#6841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%{systemd_svcs} rpm macro bug in zfs-0.7.3-1.el7_4.x86_64.rpm from zfs-kmod repo
4 participants