OS-682: ARC minimum is set too high, potentially blocking VM creation #651
Conversation
|
This change appears to be exclusive to SmartOS. It is not present in illumos-gate. |
|
We've seen similar issue but expect them to be resolved when the pending VM change is merged. By chance has he tried that patch on his 32-bit systems with VMs? |
|
He tried your patch, but if I recall, he was unable to increase the memory available to ARC without patching this code. At this point, he has switched to FreeNAS, so he is unable to do further testing at this time. I need to review his mailing list posts from that time to double check that this patch in particular would have been helpful to him. |
|
OK, In that case I'm going to hold of merging this particular change until we have a specific use/test case which shows it's a good idea. |
|
I have no plans to work on 32-bit support for the foreseeable future, so I will close this pull request for now. I will revisit this if any users contact me for help getting things work on 32-bit. |
|
dawid in #gentoo-chat on freenode has informed me that applying this patch along with setting vmalloc=256M fixed issues for him on a Pentium 4 system running Gentoo Linux. He sent an email to the zfs-devel list so that people can ask questions regarding his configuration. I am reopening this pull request. |
|
@behlendorf I do not think that this pull request is appropriate to merge, but I am leaving it open as a place for discussion of how to fix the excessive reclaim issue on 32-bit. I have asked dawid to try recompiling the latest GIT code with the spl_register_shrinker and spl_unregister_shrinker lines disabled. Hopefully, that will enable us to narrow the cause of the problem. |
|
If we believe it will help 32-bit systems, and it seems to, we could just wrap this chunk of code in a conditional so it's only applied to 32-bit builds. #if !defined(__i386) ... #endif |
Ported-by: Richard Yao <[email protected]>
Reviewed-by: Tim Chase <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Richard Elling <[email protected]> Closes openzfs#652 Closes openzfs#651
The lines that this commit deletes caused issues for adeel when he tried using ZFS on 32-bit Linux. If I recall correctly, he had to comment them out. Upon seeing that SmartOS has removed them, it might be wise to follow suit.