Change U16 to U32 due to atomic_inc_32_nv #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
reviewed
Apr 21, 2017
module/zfs/qat_compress.c
Outdated
| @@ -105,7 +105,7 @@ static CpaInstanceHandle dc_inst_handles[MAX_INSTANCES]; | |||
| static CpaDcSessionHandle session_handles[MAX_INSTANCES]; | |||
| static CpaBufferList **buffer_array[MAX_INSTANCES]; | |||
| static Cpa16U num_inst = 0; | |||
There was a problem hiding this comment.
I'd suggest changing num_inst to a Cpa32U too.
After run a long time with QAT compression, the variable "inst_num" is overflow by "atomic_inc_32_nv", which causes its neighbor variable overwritten. Change its definition from U16 to U32. Signed-off-by: Weigang Li <[email protected]>
wli5
changed the title
|
@behlendorf Thanks for review. I've changed "num_inst" to CpaU32 also, and rebased with the latest master code. |
behlendorf
approved these changes
Apr 24, 2017
behlendorf
approved these changes
Apr 26, 2017
adilger
referenced
this pull request
Apr 18, 2018
This patch adds support for acceleration of AES-GCM encryption with Intel Quick Assist Technology. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Chengfeix Zhu <[email protected]> Signed-off-by: Weigang Li <[email protected]> Signed-off-by: Tom Caputi <[email protected]> Closes #7282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After run a long time with QAT compression, the variable "inst_num"
is overflow by "atomic_inc_32_nv", which causes its neighbor
variable overwritten. Change its definition from U16 to U32.
Signed-off-by: Weigang Li [email protected]
Description
Change "inst_num" from U16 to U32 in qat_compress.c
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.