Reduce size of zvol and enforce 4k blocksize in zvol tests #5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dinatale2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @behlendorf, @sydneyvanda and @ahrens to be potential reviewers. |
dinatale2
force-pushed
the
zvol_ENOSPC_fix
branch
from
17ef595 to
1b1d326
Compare
|
Corrected an issue with how I was setting create_args in the lib. If you wouldn't mind taking another glance at it @kpande |
behlendorf
requested changes
Feb 28, 2017
| @@ -39,8 +39,9 @@ DISK=${DISKS%% *} | |||
| if is_mpath_device $DISK; then | |||
| delete_partitions | |||
| fi | |||
| BLOCKSIZE="4K" | |||
There was a problem hiding this comment.
We should define this in zvol.cfg with the others
dinatale2
force-pushed
the
zvol_ENOSPC_fix
branch
from
1b1d326 to
16fbd09
Compare
|
Do you want me to introduce blocksize to each default_zvol_setup call as well? |
behlendorf
requested changes
Feb 28, 2017
| @@ -35,18 +35,25 @@ | |||
| # Create a simple zvol volume | |||
| # | |||
| # Where disk_device: is the name of the disk to be used | |||
| # volume_size: is the size of the volume, e.g. 2G | |||
| # volume_size: is the size of the volume, e.g. 2Gi | |||
dinatale2
force-pushed
the
zvol_ENOSPC_fix
branch
2 times, most recently
from
9891acc to
fc00977
Compare
32 bit builders in the buildbot are having trouble completing their ENOSPC testing. Reduce the zvol size and ensure we use 4k blocksizes so the test is less likely to time out. Signed-off-by: Giuseppe Di Natale <[email protected]>
dinatale2
force-pushed
the
zvol_ENOSPC_fix
branch
from
fc00977 to
a1bc049
Compare
behlendorf
approved these changes
Feb 28, 2017
gmelikov
approved these changes
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Poor write performance on 32-bit buildbot builders is causing zvol ENOSPC testing to time out.
Motivation and Context
Adjust zvol size to be 256mb instead of 1g to ensure the ENOSPC testing finishes within the 10min timeout. Ensure block size is 4k which should match page sizes.
How Has This Been Tested?
Ubuntu 14.04 EC2 instance running the same AMI the 32-bit builders run.
Types of changes
Checklist: