Match on word for excluding pools from tests #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running tests locally were failing on cleanup scripts due to having a pool named "pool". Match on word so the cleanup logic will cleanup "testpool.*" while ignoring "pool". Signed-off-by: Tim Crawford <[email protected]>
|
@crawfxrd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @behlendorf, @loli10K and @tonyhutter to be potential reviewers. |
gmelikov
approved these changes
Jan 30, 2017
dinatale2
approved these changes
Jan 30, 2017
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
Running tests locally were failing on cleanup scripts due to having a pool named "pool". Match on word so the cleanup logic will cleanup "testpool.*" while ignoring "pool". Reviewed-by: loli10K <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Tim Crawford <[email protected]> Closes openzfs#5703
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
Running tests locally were failing on cleanup scripts due to having a pool named "pool". Match on word so the cleanup logic will cleanup "testpool.*" while ignoring "pool". Reviewed-by: loli10K <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Tim Crawford <[email protected]> Closes openzfs#5703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Match on word so the cleanup logic will cleanup
testpool.*while ignoringpool.Motivation and Context
Running tests locally were failing on cleanup scripts due to having a pool named
pool.How Has This Been Tested?
Running a subset of tests locally with a pool named
pooland with/without the grep flag.Types of changes
Checklist: