-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire .write/.read file operations #5588
Conversation
@behlendorf, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ryao, @tuxoko and @dweeezil to be potential reviewers. |
616cbf4
to
1b842e3
Compare
Unfortunately the prototype of |
Not surprisingly it looks like we're going to need a wrapper function and configure check for |
1b842e3
to
230c03e
Compare
The .write/.read file operations callbacks can be retired since support for .read_iter/.write_iter and .aio_read/.aio_write has been added. The vfs_write()/vfs_read() entry functions will select the correct interface for the kernel. This is desirable because all VFS write/read operations now rely on common code. This change also add the generic write checks to make sure that ulimits are enforced correctly on write. A similar check was added to zpl_fallocate() so the truncate case is also handled properly. Signed-off-by: Brian Behlendorf <[email protected]> Issue openzfs#5587
@tuxoko I'll see about adding some compatibility code for the prototype early next week assuming you're OK with the overall approach taken in this patch. |
@behlendorf |
I'll add it when I next refresh this. |
Superseded by #5673. |
The .write/.read file operations callbacks can be retired since
support for .read_iter/.write_iter and .aio_read/.aio_write has
been added. The vfs_write()/vfs_read() entry functions will
select the correct interface for the kernel. This is desirable
because all VFS write/read operations now rely on common code.
This change also add the generic write checks to make sure that
ulimits are enforced correctly on write. A similar check was
added to zpl_fallocate() so the truncate case is also handled
properly.