Don't persist temporary pool name on devices #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a regression accidentally introduced by e0ab3ab. Additionally, add a new script zpool_import_014_pos.ksh to the ZFS test suite to exercise 'zpool import -t' functionality. Signed-off-by: loli10K <[email protected]>
|
@loli10K, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jas14, @behlendorf and @ahrens to be potential reviewers. |
behlendorf
approved these changes
Dec 21, 2016
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
Fix a regression accidentally introduced by e0ab3ab. Additionally, add a new script zpool_import_014_pos.ksh to the ZFS test suite to exercise 'zpool import -t' functionality. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes openzfs#5466 Closes openzfs#5515
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
Fix a regression accidentally introduced by e0ab3ab. Additionally, add a new script zpool_import_014_pos.ksh to the ZFS test suite to exercise 'zpool import -t' functionality. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes openzfs#5466 Closes openzfs#5515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporary pool names (
zpool import -t poolname tempname) should not be persisted to disk (kind of defeats the purpose of being "temporary"). This is a regression accidentally introduced in e0ab3ab.Motivation and Context
Fixes #5466
How Has This Been Tested?
Tested with script similar to the one included in commit.
Types of changes
Checklist: