Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenZFS 7303 - dynamic metaslab selection #5404

Merged
merged 1 commit into from
Jan 12, 2017
Merged

OpenZFS 7303 - dynamic metaslab selection #5404

merged 1 commit into from
Jan 12, 2017

Conversation

don-brady
Copy link
Contributor

This change introduces a new weighting algorithm to improve metaslab selection. The new weighting algorithm relies on the SPACEMAP_HISTOGRAM feature. As a result, the metaslab weight now encodes the type of weighting algorithm used (size-based vs segment-based).

Authored by: George Wilson [email protected]
Reviewed by: Alex Reece [email protected]
Reviewed by: Chris Siden [email protected]
Reviewed by: Dan Kimmel [email protected]
Reviewed by: Matthew Ahrens [email protected]
Reviewed by: Paul Dagnelie [email protected]
Reviewed by: Pavel Zakharov [email protected]
Reviewed by: Prakash Surya [email protected]
Reviewed by: Don Brady [email protected]
Ported-by: Don Brady [email protected]

OpenZFS-issue: https://www.illumos.org/issues/7303
OpenZFS-commit: openzfs/openzfs@8710fccea7

Porting Notes: The metaslab allocation tracing code is conditionally removed on linux (dependent on mdb debugger).

@mention-bot
Copy link

@don-brady, thanks for your PR! By analyzing the history of the files in this pull request, we identified @grwilson, @behlendorf and @ahrens to be potential reviewers.

@behlendorf
Copy link
Contributor

@don-brady sorry about letting this PR get stale. Could you please rebase it on master to resolve the minor merge conflict so we can get it merged.

This change introduces a new weighting algorithm to improve
metaslab selection. The new weighting algorithm relies on the
SPACEMAP_HISTOGRAM feature. As a result, the metaslab weight
now encodes the type of weighting algorithm used (size-based
vs segment-based).

Authored by: George Wilson <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Reviewed by: Chris Siden <[email protected]>
Reviewed by: Dan Kimmel <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: Paul Dagnelie <[email protected]>
Reviewed by: Pavel Zakharov [email protected]
Reviewed by: Prakash Surya <[email protected]>
Reviewed by: Don Brady <[email protected]>
Approved by:
Ported-by: Don Brady <[email protected]>

OpenZFS-issue: https://www.illumos.org/issues/7303
OpenZFS-commit: openzfs/openzfs@d5190931bd

Porting Notes: The metaslab allocation tracing code is conditionally
               removed on linux (dependent on mdb debugger).
@don-brady
Copy link
Contributor Author

Rebased with latest master.

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@behlendorf behlendorf merged commit 4e21fd0 into openzfs:master Jan 12, 2017
wli5 pushed a commit to wli5/zfs that referenced this pull request Feb 28, 2017
This change introduces a new weighting algorithm to improve
metaslab selection. The new weighting algorithm relies on the
SPACEMAP_HISTOGRAM feature. As a result, the metaslab weight
now encodes the type of weighting algorithm used (size-based
vs segment-based).

Porting Notes: The metaslab allocation tracing code is conditionally
removed on linux (dependent on mdb debugger).

Authored by: George Wilson <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Reviewed by: Chris Siden <[email protected]>
Reviewed by: Dan Kimmel <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: Paul Dagnelie <[email protected]>
Reviewed by: Pavel Zakharov [email protected]
Reviewed by: Prakash Surya <[email protected]>
Reviewed by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Ported-by: Don Brady <[email protected]>

OpenZFS-issue: https://www.illumos.org/issues/7303
OpenZFS-commit: openzfs/openzfs@d5190931bd
Closes openzfs#5404
wli5 pushed a commit to wli5/zfs that referenced this pull request Feb 28, 2017
This change introduces a new weighting algorithm to improve
metaslab selection. The new weighting algorithm relies on the
SPACEMAP_HISTOGRAM feature. As a result, the metaslab weight
now encodes the type of weighting algorithm used (size-based
vs segment-based).

Porting Notes: The metaslab allocation tracing code is conditionally
removed on linux (dependent on mdb debugger).

Authored by: George Wilson <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Reviewed by: Chris Siden <[email protected]>
Reviewed by: Dan Kimmel <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: Paul Dagnelie <[email protected]>
Reviewed by: Pavel Zakharov [email protected]
Reviewed by: Prakash Surya <[email protected]>
Reviewed by: Don Brady <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Ported-by: Don Brady <[email protected]>

OpenZFS-issue: https://www.illumos.org/issues/7303
OpenZFS-commit: openzfs/openzfs@d5190931bd
Closes openzfs#5404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants