Porting over some ICP code that was missed in #4760 #5251
Conversation
When openzfs#4760 was merged tests were added to ensure that the new checksums were working preperly. However, some of the functionality for sha2 functions were not ported over, resulting in some Coverity defects and code that would be unstable when needed in the future. This patch simply ports over the missing code and fixes the defects in the process.
|
@tcaputi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @luozhengzheng and @tonyhutter to be potential reviewers. |
There was a problem hiding this comment.
This looks good and brings our version of sha2_mod.c close to in sync with upstream. The major differences which can't, and shouldn't, be avoided are related to module init/registration, fini/unregistration, and various fixes for gcc warnings.
The only exception I see is that CRYPTO_DATA_MBLK functionality wasn't added back. But you've already clearly explained why that's the case in illumos-crypto.c so that's fine. If thanks something we ever need in the future it can be added back in then. In the meanwhile it's less code which needs to be maintained which is good.
Let me know if you're happy with this as the final version of this PR and I'll merge it.
|
@behlendorf I'm fine with it as is, but if you would like I can also add in the memory leak fixes for the destructors that we didn't add to the ICP. I'll try to get to that before the end of the day. |
|
@tcaputi let me merge this change right now as is then since I think it stands alone nicely. Then you can open a new PR with the memory leak fixes. |
|
Sounds good to me |
When #4760 was merged tests were added to ensure that the new
checksums were working preperly. However, some of the functionality
for sha2 functions were not ported over, resulting in some Coverity
defects and code that would be unstable when needed in the future.
This patch simply ports over the missing code and fixes the defects in
the process.