zloop: check if core file is generated by zdb #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `gdb` core file inspection with correct program. Signed-off-by: Gvozden Neskovic <[email protected]>
behlendorf
approved these changes
Oct 3, 2016
There was a problem hiding this comment.
Nice! This should eliminate an entire class of zloop.sh failures where no debug information is logged.
It looks like this worked correctly on all 6 TEST builders. If you can remove commit f67b1be from the PR I can get this merged.
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
gdbcore file inspection with correct program.This should properly show core information of crashes like this