Allow ZVOL bookmarks to be listed recursively #5072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| argtype = types; | ||
| if (flags & ZFS_ITER_RECURSE) { | ||
| argtype |= ZFS_TYPE_FILESYSTEM; | ||
| if (types & ZFS_TYPE_SNAPSHOT) | ||
| if (types & ZFS_TYPE_SNAPSHOT || | ||
| types & ZFS_TYPE_BOOKMARK) |
There was a problem hiding this comment.
This can be rewritten more clearly one a single line as:
if (types & (ZFS_TYPE_SNAPSHOT | ZFS_TYPE_BOOKMARK))
|
@loli10K could you rebase this against the latest master, make the suggested style change, and force update the PR. Then you should get a clean test run. The fix itself looks reasonable. |
|
Sorry, i'm not a good C programmer. EDIT: i kind of knew there was a better way to write that conditional statement, but wouldn't dare try my hand |
DeHackEd
pushed a commit
to DeHackEd/zfs
that referenced
this pull request
Oct 19, 2016
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes openzfs#4503 Closes openzfs#5072
DeHackEd
pushed a commit
to DeHackEd/zfs
that referenced
this pull request
Oct 29, 2016
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes openzfs#4503 Closes openzfs#5072
l1k
pushed a commit
to l1k/zfs
that referenced
this pull request
Apr 17, 2017
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes openzfs#4503 Closes openzfs#5072
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
May 18, 2017
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes openzfs#4503 Closes openzfs#5072
tonyhutter
pushed a commit
that referenced
this pull request
Jun 9, 2017
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes #4503 Closes #5072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to list bookmarks recursively, if the parent dataset (
-r tank/path) is a ZVOL the command fails:Fix issue #4503
EDIT: fixed checkstyle warning