libzfs: Fix missing va_end call on ENOSPC and EDQUOT cases #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch statement in function zfs_standard_error_fmt for the ENOSPC and EDQUOT cases returns immediately and unlike all other cases in the switch this does not perform the va_end call. Perform a break which ends up calling va_end rather than retutning immediately. Found by static analysis with CoverityScan 0.8.5 Closes openzfs#4900 Signed-off-by: Colin Ian King <[email protected]>
Currently there is no file open failure check when opening /etc/dfs/sharetab. The NULL hdl->libzfs_sharelib file pointer will lead to a null pointer deference when this is closed, for example, in the case where libzfs_core_init() fails and the subsequent cleanup closes hdl->libzfs_sharelib. Fix this by checking for an open failure and performing the necessary clean up if it fails and return NULL. Found by static analysis with CoverityScan 0.8.5 Closes openzfs#4902 Signed-off-by: Colin Ian King <[email protected]>
| (void) fclose(hdl->libzfs_mnttab); | ||
| free(hdl); | ||
| return (NULL); | ||
| } |
There was a problem hiding this comment.
It's probably better to remove this entirely from libzfs_init() / libzfs_close(). It's only used in It's only ever used in is_shared() and it would be better to just handle the open/close there.
|
39447c Fix missing va_end call... - LGTM |
|
Merged as: b264d9b libzfs: Fix missing va_end call on ENOSPC and EDQUOT cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch statement in function zfs_standard_error_fmt for the
ENOSPC and EDQUOT cases returns immediately and unlike all other
cases in the switch this does not perform the va_end call.
Perform a break which ends up calling va_end rather than retutning
immediately.
Found by static analysis with CoverityScan 0.8.5
Closes #4900
Signed-off-by: Colin Ian King [email protected]