Adjustments to compile with musl libc 1.1.14 #4817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raidz_bench.c defines RUSAGE_THREAD if not previously defined This may be fixed in a forthcoming musl version. zed_log.c includes unistd.h so that read, close, pipe and getpid are not implicitly defined. remaining files are corrected to include headers poll.h, errno.h, signal.h and fcntl.h from the POSIX locations. This reduces the warnings significantly when building under musl, allowing more subtle and serious warnings about implicitly defined functions to stand out.
|
Closing. The RAIDZ code which included the RUSAGE_THREAD code is being slightly refactored to remove this dependency. The other path change can be dealt with as a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raidz_bench.c defines RUSAGE_THREAD if not previously defined
This may be fixed in a forthcoming musl version.
zed_log.c includes unistd.h so that read, close, pipe and getpid
are not implicitly defined.
remaining files are corrected to include headers poll.h,
errno.h, signal.h and fcntl.h from the POSIX locations. This
reduces the warnings significantly when building under musl,
allowing more subtle and serious warnings about implicitly
defined functions to stand out.