Man page fixes #4631
Closed
Man page fixes #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Laager <[email protected]>
Signed-off-by: Richard Laager <[email protected]>
Signed-off-by: Richard Laager <[email protected]>
This change is primarily about adding inline references in the properties section to the traditional mount option names. There are some other editorial changes too. Signed-off-by: Richard Laager <[email protected]>
Signed-off-by: Richard Laager <[email protected]>
Signed-off-by: Richard Laager <[email protected]>
This commit only contains the most trivial of changes. Signed-off-by: Richard Laager <[email protected]>
There's a convention in documentation that these words not be used to mean "invalid". Signed-off-by: Richard Laager <[email protected]>
Bad copy-and-paste? Signed-off-by: Richard Laager <[email protected]>
Signed-off-by: Richard Laager <[email protected]>
Signed-off-by: Richard Laager <[email protected]>
The default value is now always listed first. Signed-off-by: Richard Laager <[email protected]>
Reviewed by: Alexander Eremin <[email protected]> Reviewed by: Gordon Ross <[email protected]> Reviewed by: Garrett D'Amore <[email protected]> References: https://www.illumos.org/issues/1502 Ported-by: Richard Laager <[email protected]> Signed-off-by: Richard Laager <[email protected]> Conflicts: man/man8/zpool.8
Reviewed by: Richard Lowe <[email protected]> Reviewed by: George Wilson <[email protected]> Approved by: Gordon Ross <[email protected]> References: https://www.illumos.org/issues/1644 Ported-by: Richard Laager <[email protected]> Signed-off-by: Richard Laager <[email protected]>
|
I've updated this to remove the changes related to "unprivileged users". I also moved some changes to the correct commits (no net effect change on the end result). I also simplified the discussion of reservations on volumes. |
|
Thanks! LGTM |
|
I found a slight issue with one change here. Fix in #4655. |
|
OK, I'll take a look. I suspect we'll end up finding a few other tweaks will want to make as well. |
behlendorf
added a commit
that referenced
this pull request
May 17, 2016
These changes should have been part of the original 930b0d4 commit but were overlooked because 193a37c had not yet been merged when the original change was ported. Signed-off-by: Brian Behlendorf <[email protected]> Issue #4631
ryao
pushed a commit
to ClusterHQ/zfs
that referenced
this pull request
Jun 7, 2016
These changes should have been part of the original 930b0d4 commit but were overlooked because 193a37c had not yet been merged when the original change was ported. Signed-off-by: Brian Behlendorf <[email protected]> Issue openzfs#4631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a pile of in-progress man page fixes from a couple years ago. I found these while cleaning up my ZFS source directory. I've cleaned everything up and it should be ready for review.