remove sanity check in replacement test #4516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In replacement test, it spawns a process to truncate a file background and make sure that the process exists 1 second later. However, the process may have finished its work and exited therefore it has the chance to report a false alarm. This patch just removed those sanity check. Signed-off-by: Jinshan Xiong <[email protected]>
|
What about moving the check before the sleep instead to at least verify the process was created. Or is truncate so fast that is still racy? |
|
@behlendorf Yes, I would think it's not safe to do so. |
|
Indeed, OK assuming everything passes this LGTM. |
ryao
pushed a commit
to ClusterHQ/zfs
that referenced
this pull request
Jun 7, 2016
In replacement test, it spawns a process to truncate a file background and make sure that the process exists 1 second later. However, the process may have finished its work and exited therefore it has the chance to report a false alarm. This patch just removed those sanity check. Signed-off-by: Jinshan Xiong <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#4516
nedbass
pushed a commit
to nedbass/zfs
that referenced
this pull request
Sep 3, 2016
In replacement test, it spawns a process to truncate a file background and make sure that the process exists 1 second later. However, the process may have finished its work and exited therefore it has the chance to report a false alarm. This patch just removed those sanity check. Signed-off-by: Jinshan Xiong <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#4516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In replacement test, it spawns a process to truncate a file background
and make sure that the process exists 1 second later. However, the
process may have finished its work and exited therefore it has the
chance to report a false alarm.
This patch just removed those sanity check.
Signed-off-by: Jinshan Xiong [email protected]