Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of NFS kernel service for systemd. #4350

Closed
wants to merge 1 commit into from
Closed

Fix name of NFS kernel service for systemd. #4350

wants to merge 1 commit into from

Conversation

ggzengel
Copy link
Contributor

This addresses zfsonlinux/pkg-zfs/issues/192.

Signed-off-by: Grischa Zengel [email protected]

@ryao
Copy link
Contributor

ryao commented Feb 19, 2016

@ggzengel Is this a typo or are there instances in which that service name is actually used? If they are both in use in different places to refer to the same thing, we might want some kind of way of doing either/or. If systemd does not support that, then maybe via some distinction detected via autotools.

@behlendorf
Copy link
Contributor

Does systemd allow you to specify multiple services like this? Also, please squash the commits which you refresh this.

@ggzengel
Copy link
Contributor Author

@ryao First I thought it was a typo, because I use ubuntu and debian. But after some investigation I found that both variants are used.
So I put both services inside.

@ggzengel
Copy link
Contributor Author

@behlendorf They use plural in there description. So it should work.
I'm just learning to use git with eclipse. So I will do squash.

PartOf=
Configures dependencies similar to Requires=, but limited to stopping and restarting of units. When systemd stops or restarts the units listed here, the action is propagated to this unit. Note that this is a one-way dependency — changes to this unit do not affect the listed units.

Before=, After=
A space-separated list of unit names.
...

Some other systems use nfs-server.
So I put both here.

Signed-off-by: Grischa Zengel <[email protected]>
nedbass pushed a commit to nedbass/zfs that referenced this pull request Aug 26, 2016
Debian based systems use nfs-kernel-server as the service name.
List both nfs-server.service and nfs-kernel-server.service so
this service will work on multiple distributions.

Signed-off-by: Grischa Zengel <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4350
nedbass pushed a commit to nedbass/zfs that referenced this pull request Sep 3, 2016
Debian based systems use nfs-kernel-server as the service name.
List both nfs-server.service and nfs-kernel-server.service so
this service will work on multiple distributions.

Signed-off-by: Grischa Zengel <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4350
nedbass pushed a commit to nedbass/zfs that referenced this pull request Sep 5, 2016
Debian based systems use nfs-kernel-server as the service name.
List both nfs-server.service and nfs-kernel-server.service so
this service will work on multiple distributions.

Signed-off-by: Grischa Zengel <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4350
nedbass pushed a commit to nedbass/zfs that referenced this pull request Sep 5, 2016
Debian based systems use nfs-kernel-server as the service name.
List both nfs-server.service and nfs-kernel-server.service so
this service will work on multiple distributions.

Signed-off-by: Grischa Zengel <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4350
tuxoko pushed a commit to tuxoko/zfs that referenced this pull request Sep 8, 2016
Debian based systems use nfs-kernel-server as the service name.
List both nfs-server.service and nfs-kernel-server.service so
this service will work on multiple distributions.

Signed-off-by: Grischa Zengel <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants