-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Illumos 5959 - clean up per-dataset feature count code #3965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vozhyk-
changed the title
[WIP] Illumos 5959 - clean up per-dataset feature count code
Illumos 5959 - clean up per-dataset feature count code
Oct 28, 2015
vozhyk-
force-pushed
the
illumos-5959
branch
4 times, most recently
from
October 28, 2015 21:49
08fdaba
to
049e88b
Compare
@vozhyk- thanks for porting this! Could you rebase this against master and force update the branch. I'd definitely like to start making progress pulling in the recent illumos changes. |
5959 clean up per-dataset feature count code Reviewed by: Toomas Soome <[email protected]> Reviewed by: George Wilson <[email protected]> Reviewed by: Alex Reece <[email protected]> Approved by: Richard Lowe <[email protected]> References: https://www.illumos.org/issues/5959 illumos/illumos-gate@ca0cc39 Porting notes: illumos code doesn't check for feature_get_refcount() returning ENOTSUP (which means feature is disabled) in zdb. zfsonlinux added a check in openzfs@784652c due to openzfs#3468. The check was reintroduced here. Ported-by: Witaut Bajaryn <[email protected]>
Rebased on master. |
goulvenriou
pushed a commit
to Alyseo/zfs
that referenced
this pull request
Dec 8, 2015
5959 clean up per-dataset feature count code Reviewed by: Toomas Soome <[email protected]> Reviewed by: George Wilson <[email protected]> Reviewed by: Alex Reece <[email protected]> Approved by: Richard Lowe <[email protected]> References: https://www.illumos.org/issues/5959 illumos/illumos-gate@ca0cc39 Porting notes: illumos code doesn't check for feature_get_refcount() returning ENOTSUP (which means feature is disabled) in zdb. zfsonlinux added a check in openzfs@784652c due to openzfs#3468. The check was reintroduced here. Ported-by: Witaut Bajaryn <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#3965
kernelOfTruth
pushed a commit
to kernelOfTruth/zfs
that referenced
this pull request
Aug 27, 2017
5959 clean up per-dataset feature count code Reviewed by: Toomas Soome <[email protected]> Reviewed by: George Wilson <[email protected]> Reviewed by: Alex Reece <[email protected]> Approved by: Richard Lowe <[email protected]> References: https://www.illumos.org/issues/5959 illumos/illumos-gate@ca0cc39 Porting notes: illumos code doesn't check for feature_get_refcount() returning ENOTSUP (which means feature is disabled) in zdb. zfsonlinux added a check in 784652c due to openzfs#3468. The check was reintroduced here. Ported-by: Witaut Bajaryn <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#3965 Ported-by (0.6.5 branch): kernelOfTruth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5959 clean up per-dataset feature count code
Reviewed by: Toomas Soome [email protected]
Reviewed by: George Wilson [email protected]
Reviewed by: Alex Reece [email protected]
Approved by: Richard Lowe [email protected]
References:
https://www.illumos.org/issues/5959
illumos/illumos-gate@ca0cc39
Porting notes:
illumos code doesn't check for feature_get_refcount() returning ENOTSUP
(which means feature is disabled) in zdb. zfsonlinux added a check in
784652c due to #3468. The check
was reintroduced here.
Ported-by: Witaut Bajaryn [email protected]