Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illumos 5959 - clean up per-dataset feature count code #3965

Closed
wants to merge 1 commit into from

Conversation

vozhyk-
Copy link
Contributor

@vozhyk- vozhyk- commented Oct 28, 2015

5959 clean up per-dataset feature count code
Reviewed by: Toomas Soome [email protected]
Reviewed by: George Wilson [email protected]
Reviewed by: Alex Reece [email protected]
Approved by: Richard Lowe [email protected]

References:
https://www.illumos.org/issues/5959
illumos/illumos-gate@ca0cc39

Porting notes:

illumos code doesn't check for feature_get_refcount() returning ENOTSUP
(which means feature is disabled) in zdb. zfsonlinux added a check in
784652c due to #3468. The check
was reintroduced here.

Ported-by: Witaut Bajaryn [email protected]

@vozhyk- vozhyk- changed the title [WIP] Illumos 5959 - clean up per-dataset feature count code Illumos 5959 - clean up per-dataset feature count code Oct 28, 2015
@vozhyk- vozhyk- force-pushed the illumos-5959 branch 4 times, most recently from 08fdaba to 049e88b Compare October 28, 2015 21:49
@behlendorf
Copy link
Contributor

@vozhyk- thanks for porting this! Could you rebase this against master and force update the branch. I'd definitely like to start making progress pulling in the recent illumos changes.

5959 clean up per-dataset feature count code
Reviewed by: Toomas Soome <[email protected]>
Reviewed by: George Wilson <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Approved by: Richard Lowe <[email protected]>

References:
  https://www.illumos.org/issues/5959
  illumos/illumos-gate@ca0cc39

Porting notes:

illumos code doesn't check for feature_get_refcount() returning
ENOTSUP (which means feature is disabled) in zdb. zfsonlinux added
a check in openzfs@784652c
due to openzfs#3468. The check was reintroduced here.

Ported-by: Witaut Bajaryn <[email protected]>
@vozhyk-
Copy link
Contributor Author

vozhyk- commented Dec 4, 2015

Rebased on master.

@behlendorf
Copy link
Contributor

@vozhyk- LGTM, merged!

241b541 Illumos 5959 - clean up per-dataset feature count code

@behlendorf behlendorf closed this in 241b541 Dec 4, 2015
@behlendorf behlendorf reopened this Dec 4, 2015
@behlendorf behlendorf closed this Dec 4, 2015
goulvenriou pushed a commit to Alyseo/zfs that referenced this pull request Dec 8, 2015
5959 clean up per-dataset feature count code
Reviewed by: Toomas Soome <[email protected]>
Reviewed by: George Wilson <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Approved by: Richard Lowe <[email protected]>

References:
  https://www.illumos.org/issues/5959
  illumos/illumos-gate@ca0cc39

Porting notes:

illumos code doesn't check for feature_get_refcount() returning
ENOTSUP (which means feature is disabled) in zdb. zfsonlinux added
a check in openzfs@784652c
due to openzfs#3468. The check was reintroduced here.

Ported-by: Witaut Bajaryn <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#3965
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 27, 2017
5959 clean up per-dataset feature count code
Reviewed by: Toomas Soome <[email protected]>
Reviewed by: George Wilson <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Approved by: Richard Lowe <[email protected]>

References:
  https://www.illumos.org/issues/5959
  illumos/illumos-gate@ca0cc39

Porting notes:

illumos code doesn't check for feature_get_refcount() returning
ENOTSUP (which means feature is disabled) in zdb. zfsonlinux added
a check in 784652c
due to openzfs#3468. The check was reintroduced here.

Ported-by: Witaut Bajaryn <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#3965

Ported-by (0.6.5 branch): kernelOfTruth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants