[WIP] Illumos 5746 more checksumming in zfs send #3573
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed by: Christopher Siden [email protected]
Reviewed by: George Wilson [email protected]
Reviewed by: Bayard Bell [email protected]
Approved by: Albert Lee [email protected]
References:
illumos/illumos-gate@98110f0
https://www.illumos.org/issues/5746
Porting notes:
Some of those changes were somewhat hard to track due to:
2024041 Remove superfluous statement
044baf0 Use taskq for dump_bytes()
88904bb Illumos 5162 - zfs recv should use loaned arc buffer to avoid copy
kmem_alloc calls were changed to vmem_alloc
in accordance with 77aef6f (Use vmem_alloc() for nvlists) and the kmem-rework
account for ISO C90 warnings (-Werror=declaration-after-statement)
account for error: format '%llx' expects argument of type 'long long unsigned int', but argument X has type 'uint64_t' [-Werror=format=]
arc_buf_t *abuf;
dmu_buf_t *bonus;
zio_cksum_t cksum_orig;
zio_cksum_t *cksump;
Fix whitespace
change
(void) fprintf(stderr, "ERROR; failed to allocate %u bytes\n",
(unsigned)size);
to
(void) fprintf(stderr, "ERROR; failed to allocate %zu bytes\n",
size);
and to account for long unsigned int & match upstream
This commit still has to be adapted in accordance with 044baf0 (Use taskq for dump_bytes()) (?)
Ported-by: kernelOfTruth [email protected]