Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Illumos 5746 more checksumming in zfs send #3573

Conversation

kernelOfTruth
Copy link
Contributor

Reviewed by: Christopher Siden [email protected]
Reviewed by: George Wilson [email protected]
Reviewed by: Bayard Bell [email protected]
Approved by: Albert Lee [email protected]

References:
illumos/illumos-gate@98110f0
https://www.illumos.org/issues/5746

Porting notes:
Some of those changes were somewhat hard to track due to:
2024041 Remove superfluous statement

044baf0 Use taskq for dump_bytes()

88904bb Illumos 5162 - zfs recv should use loaned arc buffer to avoid copy

kmem_alloc calls were changed to vmem_alloc
in accordance with 77aef6f (Use vmem_alloc() for nvlists) and the kmem-rework

account for ISO C90 warnings (-Werror=declaration-after-statement)
account for error: format '%llx' expects argument of type 'long long unsigned int', but argument X has type 'uint64_t' [-Werror=format=]

arc_buf_t *abuf;
dmu_buf_t *bonus;
zio_cksum_t cksum_orig;
zio_cksum_t *cksump;

Fix whitespace

change
(void) fprintf(stderr, "ERROR; failed to allocate %u bytes\n",
(unsigned)size);
to
(void) fprintf(stderr, "ERROR; failed to allocate %zu bytes\n",
size);

and to account for long unsigned int & match upstream

This commit still has to be adapted in accordance with 044baf0 (Use taskq for dump_bytes()) (?)

Ported-by: kernelOfTruth [email protected]

@kernelOfTruth kernelOfTruth force-pushed the zfs_master_01.07.2015_illumos-5746 branch 3 times, most recently from 1c2fe6b to 87c72cf Compare July 6, 2015 23:03
@kernelOfTruth kernelOfTruth changed the title Illumos 5746 more checksumming in zfs send [WIP] Illumos 5746 more checksumming in zfs send Jul 7, 2015
@kernelOfTruth kernelOfTruth force-pushed the zfs_master_01.07.2015_illumos-5746 branch from 87c72cf to 7903968 Compare July 19, 2015 18:55
Reviewed by: Christopher Siden <[email protected]>
Reviewed by: George Wilson <[email protected]>
Reviewed by: Bayard Bell <[email protected]>
Approved by: Albert Lee <[email protected]>

References:
illumos/illumos-gate@98110f0
https://www.illumos.org/issues/5746

openzfs#905
(Add "zstreamdump" integrity check program openzfs#905)
openzfs@b79fc3f
(Add zstreamdump(8) command to examine ZFS send streams.)

Porting notes:
Some of those changes were somewhat hard to track due to:
openzfs@2024041 Remove superfluous statement

openzfs@044baf0 Use taskq for dump_bytes()

openzfs@88904bb Illumos 5162 - zfs recv should use loaned arc buffer to avoid copy

kmem_alloc calls were changed to vmem_alloc
in accordance with openzfs@77aef6f (Use vmem_alloc() for nvlists) and the kmem-rework

account for ISO C90 warnings (-Werror=declaration-after-statement)
account for error: format '%llx' expects argument of type 'long long unsigned int', but argument X has type 'uint64_t' [-Werror=format=]

arc_buf_t *abuf;
dmu_buf_t *bonus;
zio_cksum_t cksum_orig;
zio_cksum_t *cksump;

Fix whitespace

change
(void) fprintf(stderr, "ERROR; failed to allocate %u bytes\n",
(unsigned)size);
to
(void) fprintf(stderr, "ERROR; failed to allocate %zu bytes\n",
size);

and to account for long unsigned int & match upstream

Ported-by: kernelOfTruth [email protected]
@kernelOfTruth kernelOfTruth force-pushed the zfs_master_01.07.2015_illumos-5746 branch from 7903968 to edfb86e Compare July 19, 2015 18:57
@kernelOfTruth
Copy link
Contributor Author

Yes, yes Mr. Buildbot, Sir,

I'll add the 4.2 kernel support ASAP - or better rebase :/ :smirk_cat:

@kernelOfTruth
Copy link
Contributor Author

Closing in favor of #3611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants