Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchset for compatibility with musl libc #2604

Closed
wants to merge 11 commits into from
Closed

Conversation

stef
Copy link

@stef stef commented Aug 16, 2014

this patch set contains changes to zfsonlinux so it compiles with musl an alternative libc that ships with alpine linux for example. The biggest patch is the support for TIRPC an external RPC library, since musl does not ship such functionality.

@stef
Copy link
Author

stef commented Aug 17, 2014

will try to fix the results of this: http://buildbot.zfsonlinux.org/console?branch=refs/pull/2604/head

@behlendorf
Copy link
Contributor

@stef Nice job cleaning up this patch stack. If you can resolve the build failures we can probably get this in.

@behlendorf behlendorf mentioned this pull request Aug 17, 2014
@stef stef mentioned this pull request Sep 14, 2014
@stef
Copy link
Author

stef commented Sep 14, 2014

please consider the follow-up patch at: #2699

@stef stef closed this Sep 14, 2014
@stef
Copy link
Author

stef commented Jul 13, 2015

re: licensing of libtirpc

ryao commented on config/musl.m4 in 20e5610 on Aug 18, 2014

libtirpc is GPLv2 licensed. We cannot link to it in a manner that permits redistribution. We will need to port the Transport-Independent RPC library from Illumos.

and later:

ryao commented on module/nvpair/nvpair.c in 20e5610 on Aug 18, 2014

...
Unfortunately, we cannot do that due to the library license.

it seems that libtirpc is in fact 3 clause BSD licensed, and the license is wrong in the alpine linux APKBUILD file.

@ryao
Copy link
Contributor

ryao commented Dec 2, 2015

@stef It is wrong in the Gentoo ebuild file too. I have filed a bug:

https://bugs.gentoo.org/show_bug.cgi?id=567362

If you add autotools checks so that libtirpc can be used as a fallback and building against glibc does not break, we can merge this.

@prometheanfire
Copy link
Contributor

do we want to reopen this then or comment on a related issue?

@ryao
Copy link
Contributor

ryao commented Dec 2, 2015

@prometheanfire I cannot reopen this. @stef or @behlendorf could though.

@behlendorf
Copy link
Contributor

If we can get the patch stack refreshed against the latest master so it can be applied we can definitely revisit this so it can be applied.

@stef
Copy link
Author

stef commented Dec 2, 2015

i'm not sure i have the time in the short term for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants