Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parallel build trees (VPATH builds) #2378

Closed
wants to merge 1 commit into from

Conversation

FransUrbo
Copy link
Contributor

Add VPATH to make sure it's possible in a different directory and not
clutter the source with build results (such as Makefiles, *.o and *.a
files etc).

See openzfs/spl#362 for SPL part of the fix.

Closes: #1082

@behlendorf
Copy link
Contributor

@FransUrbo Can you rebase this on master and repush it so we can get it tested.

behlendorf referenced this pull request in ryao/zfs Aug 29, 2014
Since we changed the default location for the kernel headers to respect
--prefix in the SPL, we must search that location to prevent user builds
from breaking.

Signed-off-by: Richard Yao <[email protected]>
@FransUrbo FransUrbo closed this Feb 8, 2015
@FransUrbo
Copy link
Contributor Author

@behlendorf Could we get something like this in before 0.6.5?

@behlendorf
Copy link
Contributor

Sure if we can get patches we're happy with. I recall we ran in to some issues last time we looked at this.

@FransUrbo FransUrbo reopened this Jul 1, 2015
@FransUrbo
Copy link
Contributor Author

I've reopened and refreshed this. "Works for me", although I have yet to figure out how to run autoreconf from some other place than the top source dir. It leaves 'stuff' behind, which would be nice to get rid of.

With this, we technically don't need any .gitignore files, but I have not included the removal of them in the PR. Might need some discussion perhaps?

@behlendorf
Copy link
Contributor

@FransUrbo can you rebase this branch on master and force update it to trigger the automated testing.

@behlendorf behlendorf added this to the 0.6.5 milestone Jul 1, 2015
Support 'out of tree' builds by adding the 'src' and 'obj' variables
and removing the absolute path to the build results to the Makefile.in
files below the module directory.

Signed-off-by: Turbo Fredriksson <[email protected]>
Closes openzfs#1082
@FransUrbo
Copy link
Contributor Author

Thought I did, but apparently not. I've done that now.

@behlendorf
Copy link
Contributor

Refreshed, slightly modified, and merged as:

47a4a6f Support parallel build trees (VPATH builds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building out of tree results in build products in original source tree
2 participants