zfs send -p send properties only for snapshots that are actually sent #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed.
The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
|
@avg-I I see no reason not to include the entire commit from FreeBSD in this pull request: |
|
@behlendorf This looks good to me. |
Closed
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Aug 19, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Aug 21, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Aug 29, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 5, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 5, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 5, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 5, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 7, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 10, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 14, 2014
…send properties only for snapshots that are actually sent. zfs send -p send properties only for snapshots that are actually sent ... as opposed to sending properties of all snapshots of the relevant filesystem. The previous behavior results in properties being set on all snapshots on the receiving side, which is quite slow. More details are here: http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346 Behavior of zfs send -R is not changed. send_iterate_fs: orderly iterate snapshots The previous commit depends on ordered iteration of the snapshots, otherwise the code won't be able to correctly detect snapshots that fall into the requested snapshot range. This commit can be considered a partial cherry-pick of commit freebsd/freebsd-src@4995789cde5 where ordered iteration was introduced to fix a different problem. We might want to pick up the complete fix eventually.
Closed
|
Superseded by #2729 so this should be closed. |
|
Closing, replaced by #2729. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as opposed to sending properties of all snapshots of the relevant
filesystem. The previous behavior results in properties being set on
all snapshots on the receiving side, which is quite slow.
More details are here:
http://thread.gmane.org/gmane.comp.file-systems.openzfs.devel/346
Behavior of zfs send -R is not changed.