Fixed memory leaks in zevent handling #2291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thegreatgazoo I've refreshed this against master and slightly reworked it. If you could review it that would be helpful! |
|
@behlendorf Shouldn't this be taged 0.6.3? |
|
@FransUrbo It would certainly be nice to get in but the code here is a bit subtle so I wanted to make sure it was carefully reviewed by at least one other person familiar with the code. The leaks themselves are particularly unlikely so I don't think it's critical that it make 0.6.3. But if we can get it reviewed in the next few days we could get it in. |
|
@behlendorf Ok, fair enough. |
Some nvlist_t could be leaked in error handling paths. Also make sure cb argument to zfs_zevent_post() cannnot be NULL. Signed-off-by: Isaac Huang <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Issue openzfs#2158
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Aug 19, 2014
… handling. Fixed memory leaks in zevent handling Some nvlist_t could be leaked in error handling paths. Also make sure cb argument to zfs_zevent_post() cannnot be NULL. Signed-off-by: Isaac Huang <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Issue openzfs#2158
|
Merged as: 0426c16 Fixed memory leaks in zevent handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nvlist_t could be leaked in error handling paths.
Also make sure cb argument to zfs_zevent_post() cannnot
be NULL.
Signed-off-by: Isaac Huang [email protected]
Signed-off-by: Brian Behlendorf [email protected]
Issue #2158