Inform OpenRC that ZFS uses mtab #2148

ryao · 2014-02-27T05:08:28Z

p_l in #zfsonlinux reported that he had issues mounting filesystems that
were resolved by adding rc_need="mtab" to /etc/init.d/zfs. Closer
inspection revealed that we do have a race, but it is not clear how this
race caused mounting to fail. What is clear is that this race should be
fixed, so lets add the proper use mtab line to handle it.

Signed-off-by: Richard Yao [email protected]

p_l in #zfsonlinux reported that he had issues mounting filesystems that were resolved by adding rc_need="mtab" to /etc/init.d/zfs. Closer inspection revealed that we do have a race, but it is not clear how this race caused mounting to fail. What is clear is that this race should be fixed, so lets add the proper `use mtab` line to handle it. Signed-off-by: Richard Yao <[email protected]>

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab.

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run.

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe.

p_l in #zfsonlinux reported that he had issues mounting filesystems that were resolved by adding rc_need="mtab" to /etc/init.d/zfs. Closer inspection revealed that we do have a race, but it is not clear how this race caused mounting to fail. What is clear is that this race should be fixed, so lets add the proper `use mtab` line to handle it. Signed-off-by: Richard Yao <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#2148

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe.

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work.

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports.

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports.

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports.

… init scripts included with Debian GNU/Linux Base scripts on the init scripts included with Debian GNU/Linux then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports.

then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports.

… init scripts included with Debian GNU/Linux Base scripts on the init scripts included with Debian GNU/Linux then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports.

…ripts included with Debian GNU/Linux Base scripts on the init scripts included with Debian GNU/Linux then take code from the already existing ones, trying to merge them into one. + NFS server service is just called 'nfs' in Redhat based system, and nfs-kernel-server on Debian GNU/Linux based. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Stop after umountfs + When stopping, don't check for LOCKDIR/zfs-mount - it won't be mounted, so the file won't exist making the script not run. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports.

* Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports. + ZED script from the Debian GNU/Linux packages added. Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

…tems * Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports. + ZED script from the Debian GNU/Linux packages added. Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

* Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports. + ZED script from the Debian GNU/Linux packages added. Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

* Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports. + ZED script from the Debian GNU/Linux packages added. + Run all scripts through ShellCheck. Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

* Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports. + ZED script from the Debian GNU/Linux packages added. + All scripts passes ShellCheck (with one false positive in zfs-mount:do_mount()). Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

* Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. + Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. + Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. + The import function, do_import(), imports pools by name instead of '-a' [all]. + Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. + Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. + Add exceptions to pool imports. + All scripts passes ShellCheck (with one false positive in zfs-mount:do_mount()). + ZED script from the Debian GNU/Linux packages added. + Refreshed ZED init script from behlendorf/zfs@5e7a660. Reworked to be portable so it may be used on LSB and Redhat style systems. Signed-off-by: Brian Behlendorf <[email protected]> Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

* Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. * Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. * Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. * The import function, do_import(), imports pools by name instead of '-a' [all]. * Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. * Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. * Add exceptions to pool imports. * All scripts passes ShellCheck (with one false positive in zfs-mount:do_mount()). * ZED script from the Debian GNU/Linux packages added. * Refreshed ZED init script from behlendorf/zfs@5e7a660 to be portable so it may be used on both LSB and Redhat style systems. Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

…tems * Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. * Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. * Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. * The import function, do_import(), imports pools by name instead of '-a' [all]. * Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. * Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. * Add exceptions to pool imports. * All scripts passes ShellCheck (with one false positive in zfs-mount:do_mount()). * ZED script from the Debian GNU/Linux packages added. * Refreshed ZED init script from behlendorf/zfs@5e7a660 to be portable so it may be used on both LSB and Redhat style systems. Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

* Based on the init scripts included with Debian GNU/Linux, then take code from the already existing ones, trying to merge them into one for better maintainability. * Merge openzfs#2148 - Inform OpenRC that ZFS uses mtab. * Add a configurable ZFS_INITRD_POST_MODPROBE_SLEEP used in the initrd to sleep after the modprobe. * The import function, do_import(), imports pools by name instead of '-a' [all]. * Test all '/dev/disk/by-*' dirs for import. Include /dev as a last ditch attempt. * Fallback on importing the pool using the cache file (if it exists) if the 'by-id' didn't work. * Add exceptions to pool imports. * All scripts passes ShellCheck (with one false positive in zfs-mount:do_mount()). * ZED script from the Debian GNU/Linux packages added. * Refreshed ZED init script from behlendorf/zfs@5e7a660 to be portable so it may be used on both LSB and Redhat style systems. Signed-off-by: Turbo Fredriksson [email protected] Closes: openzfs#2974, openzfs#2107.

ryao mentioned this pull request Feb 27, 2014

Complete rewrite of init script(s) #2106

Closed

behlendorf closed this in b42b812 Mar 7, 2014

behlendorf added this to the 0.6.3 milestone Mar 7, 2014

behlendorf added the Bug label Mar 7, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inform OpenRC that ZFS uses mtab #2148

Inform OpenRC that ZFS uses mtab #2148

ryao commented Feb 27, 2014

Inform OpenRC that ZFS uses mtab #2148

Inform OpenRC that ZFS uses mtab #2148

Conversation

ryao commented Feb 27, 2014