ZAP: Align za_name in zap_attribute_t to 8 bytes

[amotin]

Our code reading/writing there may not handle misaligned accesses on platforms that may care about it. I don't see a point to complicate it to satisfy UBSan in CI. This alignment costs nothing.

Fixes: #15921

How Has This Been Tested?

Not really, lets see what CI say.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[behlendorf]

Agreed. This is a no brainer and best to add the padding now.