Fixed the default checksum algorithm in the manpage. #1628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Massimo Maggi <[email protected]>
|
Thank you, merged as e43b290 Fix the default checksum algorithm in the manpage |
unya
pushed a commit
to unya/zfs
that referenced
this pull request
Dec 13, 2013
The manpage reports fletcher2, but in zio.h ZIO_CHECKSUM_ON_VALUE is defined to ZIO_CHECKSUM_FLETCHER_4. Signed-off-by: Massimo Maggi <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#1628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a mismatch between the man page and the source code about the default algorithm for checksum=on.
The manpage reports fletcher2, but zio.h (https://github.com/zfsonlinux/zfs/blob/master/include/sys/zio.h#L85) says it's fletcher4.