Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: unregister mountroot eventhandler on unload #16242

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented Jun 1, 2024

Otherwise if zfs is unloaded and reroot is being used it trips over a stale pointer.

Sponsored by: Rubicon Communications, LLC ("Netgate")
Signed-off-by: Mateusz Guzik [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Otherwise if zfs is unloaded and reroot is being used it trips over a
stale pointer.

Sponsored by:	Rubicon Communications, LLC ("Netgate")
Signed-off-by: Mateusz Guzik <[email protected]>
@mjguzik
Copy link
Contributor Author

mjguzik commented Jun 1, 2024

cc @amotin

@behlendorf behlendorf merged commit 121a2d3 into openzfs:master Jun 14, 2024
22 of 25 checks passed
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jun 14, 2024
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
Otherwise if zfs is unloaded and reroot is being used it trips over a
stale pointer.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Signed-off-by: Mateusz Guzik <[email protected]>
Closes openzfs#16242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants