Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zfetch stats in arcstats #16094

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add zfetch stats in arcstats #16094

merged 1 commit into from
Apr 19, 2024

Conversation

ixhamza
Copy link
Member

@ixhamza ixhamza commented Apr 15, 2024

Motivation and Context

arc_summary also reports zfetch stats but it's inconvenient to monitor contiguously incrementing numbers. Adding them in arcstats allows us to observe streams more conveniently.

How Has This Been Tested?

Validated that arcstats correctly shows zfetch stats with this patch

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

amotin
amotin reviewed Apr 15, 2024
View reviewed changes
cmd/arcstat.in Outdated Show resolved Hide resolved
cmd/arcstat.in Outdated Show resolved Hide resolved
cmd/arcstat.in Outdated Show resolved Hide resolved
@ixhamza
Add zfetch stats in arcstats
7b3e8d4 
arc_summary also reports zfetch stats but it's inconvenient to monitor
contiguously incrementing numbers. Adding them in arcstats allows us to
observe streams more conveniently.

Signed-off-by: Ameer Hamza <[email protected]>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 15, 2024
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 19, 2024
@behlendorf behlendorf merged commit cd3e6b4 into openzfs:master Apr 19, 2024
24 of 25 checks passed
tonyhutter pushed a commit that referenced this pull request May 2, 2024
@ixhamza @tonyhutter
Add zfetch stats in arcstats
4d17e20 
arc_summary also reports zfetch stats but it's inconvenient to monitor
contiguously incrementing numbers. Adding them in arcstats allows us to
observe streams more conveniently.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes #16094
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@ixhamza @lundman
Add zfetch stats in arcstats
32ff99e 
arc_summary also reports zfetch stats but it's inconvenient to monitor
contiguously incrementing numbers. Adding them in arcstats allows us to
observe streams more conveniently.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#16094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ixhamza @behlendorf @amotin