Fixed parameter passing error when calling zfs_acl_chmod

[yyhran]

Motivation and Context

When I created the regular file using nfsv4 acl, I found that the owner has D permission. This permission is not useful for the regular file, and it should not appear on the regular file.

root@Quartz:/pool_t1# touch test
root@Quartz:/pool_t1# nfs4xdr_getfacl test
# File: test
# owner: 0
# group: 0
# mode: 0o100644
# trivial_acl: true
# ACL flags: none
            owner@:rw-pD-aARWcCos:-------:allow
            group@:r-----a-R-c--s:-------:allow
         everyone@:r-----a-R-c--s:-------:allow

Description

The first argument of the zfs_acl_chmod should be is_dir instead of the file_mode. But zfs_acl_ids_create directly passes the mode of the file to zfs_acl_chmod. Use the S_ISDIR to obtain the file type by mode.

How Has This Been Tested?

After fixed, I got the right permission

root@Quartz:/pool_t1# touch test2
root@Quartz:/pool_t1# nfs4xdr_getfacl test2
# File: test2
# owner: 0
# group: 0
# mode: 0o100644
# trivial_acl: true
# ACL flags: none
            owner@:rw-p--aARWcCos:-------:allow
            group@:r-----a-R-c--s:-------:allow
         everyone@:r-----a-R-c--s:-------:allow

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[behlendorf]

Thanks for catching and better yet fixing this. LGTM and brings this this check in-sync with the FreeBSD code.