-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos: Search for C++ and Obj C compilers #15521
base: master
Are you sure you want to change the base?
Conversation
Has anyone had a chance to look at this yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection, but we'll want to annotate all of these macos commits so they're easy to find. We've often done that for Linux and FreeBSD by prepending "Linux: " or "FreeBSD" to the commit message subject.
Signed-off-by: Andrew Innes <[email protected]> Co-authored-by: Jorgen Lundman <[email protected]>
Done |
Thanks. I'm good with starting to bring in these macos changes. Let's just make sure all of of these commits have the "Macos:" prefix so they're easy to identify. Since some of these infrastructure may not be used yet that'll help make it clear why a change was made. |
Motivation and Context
The macos port requires additional compilers so I'm splitting the changes out to see if they break anything in non macos builds
Description
Search for C++ and Obj C compilers in configure script
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.