Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos: Search for C++ and Obj C compilers #15521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewc12
Copy link
Contributor

@andrewc12 andrewc12 commented Nov 14, 2023

Motivation and Context

The macos port requires additional compilers so I'm splitting the changes out to see if they break anything in non macos builds

Description

Search for C++ and Obj C compilers in configure script

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@andrewc12 andrewc12 marked this pull request as ready for review November 14, 2023 03:35
@andrewc12
Copy link
Contributor Author

andrewc12 commented Dec 1, 2023

Has anyone had a chance to look at this yet?

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection, but we'll want to annotate all of these macos commits so they're easy to find. We've often done that for Linux and FreeBSD by prepending "Linux: " or "FreeBSD" to the commit message subject.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 5, 2023
Signed-off-by: Andrew Innes <[email protected]>
Co-authored-by: Jorgen Lundman <[email protected]>
@andrewc12 andrewc12 changed the title Search for C++ and Obj C compilers Macos: Search for C++ and Obj C compilers Jan 17, 2024
@andrewc12
Copy link
Contributor Author

No objection, but we'll want to annotate all of these macos commits so they're easy to find. We've often done that for Linux and FreeBSD by prepending "Linux: " or "FreeBSD" to the commit message subject.

Done

@behlendorf
Copy link
Contributor

Thanks. I'm good with starting to bring in these macos changes. Let's just make sure all of of these commits have the "Macos:" prefix so they're easy to identify. Since some of these infrastructure may not be used yet that'll help make it clear why a change was made.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 17, 2024
@andrewc12 andrewc12 mentioned this pull request Jan 18, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants