Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macos: Zprop changes #15471

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Macos: Zprop changes #15471

wants to merge 7 commits into from

Conversation

andrewc12
Copy link
Contributor

@andrewc12 andrewc12 commented Oct 31, 2023 •
edited
Loading

Motivation and Context

The macos port has some abi changes that it needs to go in.
By pulling them out and getting them merged before hand we can choose when the abi breakage happens.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@andrewc12 andrewc12 marked this pull request as ready for review October 31, 2023 08:51
robn
robn reviewed Oct 31, 2023
View reviewed changes
module/zcommon/zfs_prop.c Outdated Show resolved Hide resolved
@andrewc12 andrewc12 force-pushed the zprop-abi branch 2 times, most recently from 10edcd0 to f4af83e Compare November 1, 2023 01:16
andrewc12
andrewc12 commented Nov 1, 2023
View reviewed changes
include/sys/fs/zfs.h Outdated Show resolved Hide resolved
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 1, 2023
@andrewc12 andrewc12 closed this Nov 13, 2023
@andrewc12 andrewc12 mentioned this pull request Nov 14, 2023
Closed
13 tasks
@andrewc12 andrewc12 changed the title Zprop changes for macosx Macos: Zprop changes Jan 17, 2024
@andrewc12 andrewc12 reopened this Jan 17, 2024
@andrewc12 @lundman
Macos: Zprop changes
a4f8a88 
Signed-off-by: Andrew Innes <[email protected]>
Co-Authored-By: Jorgen Lundman <[email protected]>
@andrewc12 andrewc12 force-pushed the zprop-abi branch 2 times, most recently from 1361547 to 4ea360a Compare January 17, 2024 22:53
@andrewc12 @lundman
Macos: libabigail changes
956be9a 
Signed-off-by: Andrew Innes <[email protected]>
Co-Authored-By: Jorgen Lundman <[email protected]>
@andrewc12
Macos: remove namespace from zprops
d3acfe1 
Remove prefix to avoid conflict with user-defined properties
Signed-off-by: Andrew Innes <[email protected]>
@andrewc12
Macos: zprop documentation
12a59b2 
Add a new manpage that describes the zprops used on macos
Signed-off-by: Andrew Innes <[email protected]>
Co-Authored-By: Jorgen Lundman <[email protected]>
@andrewc12
Macos: add ntfs to zprop options
13146ca 
Signed-off-by: Andrew Innes <[email protected]>
@andrewc12
Macos: add apfs ntfs to zprop man page
da0d2a9 
Signed-off-by: Andrew Innes <[email protected]>
@andrewc12
Copy link
Contributor Author

@behlendorf just letting you know about this one as well.
I've also included ntfs in the mimic zprop enum because the windows port uses the same machinery.

@andrewc12 andrewc12 mentioned this pull request Jan 18, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundman lundman lundman left review comments

@robn robn robn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewc12 @robn @lundman @behlendorf