Fix ZED auto-replace for VDEVs using by-id paths

[don-brady]

Motivation and Context

The ZFS auto-replace mechanism will detect a blank disk inserted for a degraded/faulted VDEV and automatically partition the disk and issue a VDEV replacement.

There are two different /dev/disk/by-xxx paths involved, a by-id and a by-vdev.
In the 'by-vdev' case, the path is both a persistent and physical path.
In the 'by-id' case, the path is persistent and also a unique path.
During an auto-replace, the newly partition disk will have a different 'by-id' name, however the 'by-vdev' name will not change.

A regression in the distant past, changed the ZED auto-replace code such that it is attempting to use the old 'by-id' name during the replacement but that name no longer exists in the 'by-id' namespace. This causes the auto-replace operation to fail.

Note that since the 'by-vdev' names don't change, it's perfectly fine to use the previous VDEV path when dev paths are 'by-vdev'.

Description

The change is simple -- restore the original code so that the VDEV path is updated when using by-id paths.
The more challenging part was to devise a second ZTS test, that would test auto-replace for 'by-id' and help prevent a future regression.

With that new test, we can now do an A|B test with , and without, the fix to confirm that auto-replace for by-id paths works. The existing auto-replace test, functional/fault/auto_replace_001_pos, will confirm that we didn't break auto-replace for 'by-vdev' paths.

In the original functional/fault/auto_replace_001_pos test, the disk wipe (using dd) was not effective in removing the partitioning since the kernel was never informed of the wipe.

• Added a call to wipefs(8) so that the kernel is informed and ZED will re-partition the device.
• Added a validation step that the repartitioning occurred by confirming that the GPT partition UUID changes

Sponsored-By: OpenDrives Inc.
Sponsored-By: Klara Inc.

How Has This Been Tested?

ZTS functional/fault tests
Audit ZED logging from the tests to confirm that ZED auto-replace was functioning as expected.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.